From: Boaz Harrosh <bharrosh@panasas.com>
To: James Bottomley <James.Bottomley@SteelEye.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH 8/8] Change SG_ALL to mean "any size"
Date: Thu, 17 Jan 2008 18:55:16 +0200 [thread overview]
Message-ID: <478F8874.7070705@panasas.com> (raw)
In-Reply-To: <478F8435.5000907@panasas.com>
Change the definition of SG_ALL from 255, which was the biggest possible
scatter list array in 32 bit ARCHs (minus one who knows why), to be ~0.
Which means that LLD has no size limit on number of scatter-list array
and the actual size will be determined by upper layers.
Also SG_NONE is removed because it is no longer supported.
Note: SG_ALL can not be used as an allocation size anymore.
FIXME: Important/capable drivers like iscsi have moved away from
SG_ALL to hard coded numbers like 4096. They should reuse
SG_ALL now.
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
include/scsi/scsi_host.h | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index 5c58d59..6032d07 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -21,16 +21,14 @@ struct blk_queue_tags;
/*
- * The various choices mean:
- * NONE: Self evident. Host adapter is not capable of scatter-gather.
+ * values to use with .sg_tablesize:
* ALL: Means that the host adapter module can do scatter-gather,
* and that there is no limit to the size of the table to which
* we scatter/gather data.
* Anything else: Indicates the maximum number of chains that can be
* used in one scatter-gather request.
*/
-#define SG_NONE 0
-#define SG_ALL 0xff
+#define SG_ALL (~0)
#define MODE_UNKNOWN 0x00
#define MODE_INITIATOR 0x01
--
1.5.3.3
next prev parent reply other threads:[~2008-01-17 16:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 16:37 [patch 0/8] Change SG_ALL to mean "any size" Boaz Harrosh
2008-01-17 16:41 ` [PATCH 1/8] firewire: ieee1394: Move away from SG_ALL Boaz Harrosh
2008-01-17 17:51 ` Stefan Richter
2008-01-19 7:59 ` Stefan Richter
2008-01-19 15:01 ` James Bottomley
2008-01-19 15:16 ` Stefan Richter
2008-01-17 16:44 ` [PATCH 2/8] scsi-drivers Don't use SG_ALL as allocation size Boaz Harrosh
2008-01-17 17:47 ` Andrew Vasquez
2008-01-17 18:11 ` Boaz Harrosh
2008-01-17 18:30 ` Andrew Vasquez
2008-01-17 18:57 ` [PATCH 2/8 ver2] " Boaz Harrosh
2008-01-17 16:46 ` [PATCH 3/8] NCR5380: Not sg-chain ready Boaz Harrosh
2008-01-17 16:48 ` [PATCH 4/8] wd33c93: " Boaz Harrosh
2008-01-17 16:49 ` [PATCH 5/8] arm/scsi: " Boaz Harrosh
2008-01-17 16:51 ` scsi: Drivers not ready for sg-chaining Boaz Harrosh
2008-02-10 15:42 ` James Bottomley
2008-02-10 16:08 ` Boaz Harrosh
2008-02-10 16:16 ` James Bottomley
2008-02-10 16:36 ` Boaz Harrosh
2008-02-10 16:53 ` James Bottomley
2008-01-17 16:53 ` [PATCH 7/8] a100u2w: advansys: initio: Wrong use of SG_ALL Boaz Harrosh
2008-01-17 16:55 ` Boaz Harrosh [this message]
2008-01-17 17:53 ` [patch 0/8] Change SG_ALL to mean "any size" Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=478F8874.7070705@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).