From: Tejun Heo <htejun@gmail.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
fischer@norbit.de, Andy Whitcroft <apw@shadowen.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Samuel Ortiz <samuel@sortiz.org>
Subject: Re: [PATCH] SCSI: fix isa/pcmcia compile problem
Date: Sat, 19 Jan 2008 08:54:33 +0900 [thread overview]
Message-ID: <47913C39.2070100@gmail.com> (raw)
In-Reply-To: <1200700076.3111.80.camel@localhost.localdomain>
James Bottomley wrote:
>> I'm just a bit reluctant to touch these drivers, since they're all
>> incredibly ancient. We don't have good luck with simple transformation
>> patches on the older drivers ... and it seems to take months before
>> anyone notices there's a problem.
>
> This is the patch that will return them to their original behaviour.
>
> James
>
> ---
> diff --git a/drivers/scsi/pcmcia/Kconfig b/drivers/scsi/pcmcia/Kconfig
> index fa481b5..53857c6 100644
> --- a/drivers/scsi/pcmcia/Kconfig
> +++ b/drivers/scsi/pcmcia/Kconfig
> @@ -6,7 +6,8 @@ menuconfig SCSI_LOWLEVEL_PCMCIA
> bool "PCMCIA SCSI adapter support"
> depends on SCSI!=n && PCMCIA!=n
>
> -if SCSI_LOWLEVEL_PCMCIA && SCSI && PCMCIA
> +# drivers have problems when build in, so require modules
> +if SCSI_LOWLEVEL_PCMCIA && SCSI && PCMCIA && m
>
> config PCMCIA_AHA152X
> tristate "Adaptec AHA152X PCMCIA support"
>
>
Looks good to me.
--
tejun
next prev parent reply other threads:[~2008-01-18 23:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080117023514.9df393cf.akpm@linux-foundation.org>
2008-01-17 16:15 ` 2.6.24-rc8-mm1 Build Failure on scsi driver Kamalesh Babulal
2008-01-17 19:11 ` Andrew Morton
2008-01-18 0:53 ` [PATCH] aha152x: fix isa/pcmcia compile problem Tejun Heo
2008-01-18 6:29 ` Kamalesh Babulal
2008-01-18 6:37 ` 2.6.24-rc8-mm1 Build Failure on scsi driver Kamalesh Babulal
2008-01-18 7:20 ` [PATCH] SCSI: fix isa/pcmcia compile problem Tejun Heo
2008-01-18 7:30 ` Kamalesh Babulal
2008-01-18 14:58 ` James Bottomley
2008-01-18 23:27 ` Tejun Heo
2008-01-18 23:28 ` Tejun Heo
2008-01-18 23:32 ` James Bottomley
2008-01-18 23:46 ` Tejun Heo
2008-01-18 23:47 ` James Bottomley
2008-01-18 23:54 ` Tejun Heo [this message]
2008-01-21 9:56 ` Christoph Hellwig
2008-01-21 14:59 ` James Bottomley
2008-01-18 7:27 ` 2.6.24-rc8-mm1 Build Failure on scsi driver Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47913C39.2070100@gmail.com \
--to=htejun@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=fischer@norbit.de \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).