linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/1][] Test opcode, not definition in type_check(), drivers/scsi/aic7xxx/aicasm/aicasm_gram.y
Date: Tue, 29 Jan 2008 10:43:48 +0100	[thread overview]
Message-ID: <479EF554.3000601@suse.de> (raw)
In-Reply-To: <479DD422.60006@tiscali.nl>

Roel Kluin wrote:
> drivers/scsi/aic7xxx_old/sequencer.h:130:#define AIC_OP_JZ 0xf
> --
> Test opcode, not definition
> 
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Hannes Reinecke <hare@suse.de>

> ---
> diff --git a/drivers/scsi/aic7xxx/aicasm/aicasm_gram.y b/drivers/scsi/aic7xxx/aicasm/aicasm_gram.y
> index 6066998..702e2db 100644
> --- a/drivers/scsi/aic7xxx/aicasm/aicasm_gram.y
> +++ b/drivers/scsi/aic7xxx/aicasm/aicasm_gram.y
> @@ -1837,7 +1837,7 @@ type_check(symbol_t *symbol, expression_t *expression, int opcode)
>  	int and_op;
>  
>  	and_op = FALSE;
> -	if (opcode == AIC_OP_AND || opcode == AIC_OP_JNZ || AIC_OP_JZ)
> +	if (opcode == AIC_OP_AND || opcode == AIC_OP_JNZ || opcode == AIC_OP_JZ)
>  		and_op = TRUE;
>  
>  	/*

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2008-01-29  9:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-28 13:09 [PATCH 1/1][] Test opcode, not definition in type_check(), drivers/scsi/aic7xxx/aicasm/aicasm_gram.y Roel Kluin
2008-01-29  9:43 ` Hannes Reinecke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=479EF554.3000601@suse.de \
    --to=hare@suse.de \
    --cc=12o3l@tiscali.nl \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).