From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers Date: Thu, 31 Jan 2008 21:06:39 +0200 Message-ID: <47A21C3F.5070400@panasas.com> References: <477CFC97.2010201@panasas.com> <477D0209.2000609@panasas.com> <1199384189.3122.22.camel@localhost.localdomain> <1199686061.31422.2.camel@kars.perseus.home> <1201802886.3131.35.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from gw-colo-pa.panasas.com ([66.238.117.130]:25568 "EHLO cassoulet.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760048AbYAaTHK (ORCPT ); Thu, 31 Jan 2008 14:07:10 -0500 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Geert Uytterhoeven Cc: James Bottomley , Kars de Jong , Linux/m68k , Christoph Hellwig , "Maciej W. Rozycki" , "David S. Miller" , linux-scsi On Thu, Jan 31 2008 at 20:55 +0200, Geert Uytterhoeven wrote: > On Thu, 31 Jan 2008, James Bottomley wrote: >> On Mon, 2008-01-07 at 07:07 +0100, Kars de Jong wrote: >>> On do, 2008-01-03 at 20:05 +0100, Geert Uytterhoeven wrote: >>>> On Thu, 3 Jan 2008, James Bottomley wrote: >>>>> On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote: >>>>>> As recommended by Christoph Hellwig. There is no use >>>>>> of Fixing these drivers, since there is a much simpler >>>>>> and modern esp infrastructure with David Miller's esp_scsi >>>>>> >>>>>> - Remove all driver files dependent on NCR53C9x.c >>>>>> deleted: drivers/scsi/NCR53C9x.c >>>>>> deleted: drivers/scsi/NCR53C9x.h >>>>>> deleted: drivers/scsi/blz1230.c >>>>>> deleted: drivers/scsi/blz2060.c >>>>>> deleted: drivers/scsi/cyberstorm.c >>>>>> deleted: drivers/scsi/cyberstormII.c >>>>>> deleted: drivers/scsi/dec_esp.c >>>>>> deleted: drivers/scsi/fastlane.c >>>>>> deleted: drivers/scsi/mac_esp.c >>>>>> deleted: drivers/scsi/mca_53c9x.c >>>>>> deleted: drivers/scsi/oktagon_esp.c >>>>>> deleted: drivers/scsi/oktagon_io.S >>>>>> deleted: drivers/scsi/sun3x_esp.c >>>>>> >>>>>> - Remove above list from drivers/scsi/Kconfig && >>>>>> drivers/scsi/Makefile >>>>> OK, I'll split this into four pieces for scsi-pending, since there are >>>>> three separate interest groups with signoffs to collect (MCA, m68k and >>>>> alpha) plus the core removal. >>>> Anybody who can look into converting the m68k NCR53C9x drivers and has >>>> hardware to test (some of) them? I don't think we can afford losing one >>>> third of our SCSI drivers... >>> I'll have a look at this. I can only test it on Blizzard 1260 hardware >>> though. >> OK, time's up. >> >> These drivers are now unbuildable in mainline because of the promised >> sg_table updates. They either get removed, fixed or marked as BROKEN. >> Which is it to be? > > Is git smart enough to follow history between files that get removed and > readded? > If yes, I think you can remove them. > If no, please mark them as BROKEN. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > - I did submit a fix to all these drivers, but It was said by people that these drivers should not be fixed because they have a better alternative with the other esp family. And any devices not supported by the other family should be not more then a day of work to support. So doing the better job of supporting them in the new form is less effort then resurrecting junk code from the graveyard. I say dump it. Christoph ??! Boaz