From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: ABORT_TASK defined in aic94xx_sas.h Date: Wed, 06 Feb 2008 17:34:12 +0200 Message-ID: <47A9D374.2010607@panasas.com> References: <47A9B859.6020208@panasas.com> <1202310808.3112.8.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from gw-colo-pa.panasas.com ([66.238.117.130]:27686 "EHLO cassoulet.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751526AbYBFPeX (ORCPT ); Wed, 6 Feb 2008 10:34:23 -0500 In-Reply-To: <1202310808.3112.8.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: linux-scsi , Luben Tuikov On Wed, Feb 06 2008 at 17:13 +0200, James Bottomley wrote: > On Wed, 2008-02-06 at 15:38 +0200, Boaz Harrosh wrote: >> include/scsi/scsi.h as a definition: >> #define ABORT_TASK 0x0d >> >> on the other hand drivers/scsi/aic94xx/aic94xx_sas.h has: >> #define ABORT_TASK 0x03 >> >> am I right in thinking that aic94xx_sas.h is wrong in >> polluting the global name-space? >> >> If you ask me aic94xx_sas.h is a global name-space minefield >> >> (This gives me problems when trying to pull in scsi_eh.h into >> aic94xx source files) > > Well, no, not in those terms. The global namespace exists in shared > headers which it's a little hard to argue that aic94xx_sas.h is, being > unusable by anything other than a single driver. > > It is correct to say that include/scsi/scsi.h is polluting the global > namespace, because that is pulled into a large section of the kernel. > > The message code #defines in scsi.h are a horrible mess of SPI message > defines and task management function defines each of which should > arguably have a SPI_ and TMF_ global namespace discriminator (and the > SPI_ ones be shovelled off into the SPI transport class header). > > However, this looks like a reasonable hack. > > James > > Point taken, you are right. Please see that you approve of the name I gave it, I just got it from the nearest comment so I'm not even sure if it's related. Thanks Boaz