From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash Date: Wed, 13 Feb 2008 17:54:27 +0200 Message-ID: <47B312B3.3010200@panasas.com> References: <47A19E26.30107@panasas.com> <47B1D7A8.8010108@panasas.com> <47B1DA2A.1060904@panasas.com> <1202917468.3109.5.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from bzq-219-195-70.pop.bezeqint.net ([62.219.195.70]:41374 "EHLO bh-buildlin2.bhalevy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932229AbYBMP5P (ORCPT ); Wed, 13 Feb 2008 10:57:15 -0500 In-Reply-To: <1202917468.3109.5.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: =?UTF-8?B?U3ZlbiBLw7ZobGVy?= , Christoph Hellwig , Jeff Garzik , linux-scsi , linux-kernel@vger.kernel.org, Joerg Dorchain , Jon Chelton , Stefan Priebe - allied internet ag On Wed, Feb 13 2008 at 17:44 +0200, James Bottomley wrote: > On Tue, 2008-02-12 at 19:40 +0200, Boaz Harrosh wrote: >> - gdth_flush(ha); >> - > > This piece doesn't look right. gdth_flush() forces the internal cache > to disk backing. If you remove it, you're taking the chance that the > machine will be powered off without a writeback which can cause data > corruption. > > James > Yes. I have more problems reported, with exit, and am just sending one more patch that puts this back in. Which was tested. So I will resend this one plus one new one. Boaz