From: Jiri Slaby <jirislaby@gmail.com>
To: Sergio Luis <sergio@larces.uece.br>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: "gdth: update deprecated pci_find_device" is incorrect
Date: Thu, 14 Feb 2008 15:47:05 +0100 [thread overview]
Message-ID: <47B45469.5070103@gmail.com> (raw)
In-Reply-To: <47B453D3.5060707@gmail.com>
On 02/14/2008 03:44 PM, Jiri Slaby wrote:
> Hi,
>
> commit
> 99109301d103fbf0de43fc5a580a406c12a501e0
> in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci
> refcount on exit. Also you do not so on fail paths... I wonder why these
> mistakes happen every second time somebody tries to do such change.
>
> It leaked into mainline yet after "whole" two days, but what exactly
> drives me crazy is, that Jeff commented it in similar way and nobody
> reflected it!
BTW if you have more than one card, you protected the driver from no race, since
you don't pci_dev_get of successfully grabbed cards.
next prev parent reply other threads:[~2008-02-14 14:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-14 14:44 "gdth: update deprecated pci_find_device" is incorrect Jiri Slaby
2008-02-14 14:47 ` Jiri Slaby [this message]
2008-02-14 15:00 ` Jiri Slaby
2008-02-14 15:02 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B45469.5070103@gmail.com \
--to=jirislaby@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sergio@larces.uece.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).