From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: "gdth: update deprecated pci_find_device" is incorrect Date: Thu, 14 Feb 2008 15:47:05 +0100 Message-ID: <47B45469.5070103@gmail.com> References: <47B453D3.5060707@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from nf-out-0910.google.com ([64.233.182.186]:10259 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755857AbYBNOrL (ORCPT ); Thu, 14 Feb 2008 09:47:11 -0500 Received: by nf-out-0910.google.com with SMTP id g13so233680nfb.21 for ; Thu, 14 Feb 2008 06:47:10 -0800 (PST) In-Reply-To: <47B453D3.5060707@gmail.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Sergio Luis Cc: James Bottomley , SCSI Mailing List , Jeff Garzik , Linux Kernel Mailing List On 02/14/2008 03:44 PM, Jiri Slaby wrote: > Hi, > > commit > 99109301d103fbf0de43fc5a580a406c12a501e0 > in jejb/scsi-rc-fixes-2.6.git is incorrect. You don't decrement pci > refcount on exit. Also you do not so on fail paths... I wonder why these > mistakes happen every second time somebody tries to do such change. > > It leaked into mainline yet after "whole" two days, but what exactly > drives me crazy is, that Jeff commented it in similar way and nobody > reflected it! BTW if you have more than one card, you protected the driver from no race, since you don't pci_dev_get of successfully grabbed cards.