From: Douglas Gilbert <dougg@torque.net>
To: FUJITA Tomonori <tomof@acm.org>
Cc: James.Bottomley@hansenpartnership.com,
linux-scsi@vger.kernel.org, fujita.tomonori@lab.ntt.co.jp
Subject: Re: [PATCH] scsi_debug: disable clustering
Date: Sun, 17 Feb 2008 00:53:12 -0500 [thread overview]
Message-ID: <47B7CBC8.2040209@torque.net> (raw)
In-Reply-To: <20080216235714H.tomof@acm.org>
FUJITA Tomonori wrote:
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH] scsi_debug: disable clustering
>
> scsi_debug does at several places:
>
> for_each_sg(sdb->table.sgl, sg, sdb->table.nents, k) {
> kaddr = (unsigned char *)
> kmap_atomic(sg_page(sg), KM_USER0);
>
>
> We cannot do something like that with the clustering enabled (or we
> can use scsi_kmap_atomic_sg).
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Thanks, Tomo.
Signed-off-by: Douglas Gilbert <dougg@torque.net>
> ---
> drivers/scsi/scsi_debug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index 1541c17..d1777a9 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -222,7 +222,7 @@ static struct scsi_host_template sdebug_driver_template = {
> .cmd_per_lun = 16,
> .max_sectors = 0xffff,
> .unchecked_isa_dma = 0,
> - .use_clustering = ENABLE_CLUSTERING,
> + .use_clustering = DISABLE_CLUSTERING,
> .module = THIS_MODULE,
> };
>
next prev parent reply other threads:[~2008-02-17 5:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 14:57 [PATCH] scsi_debug: disable clustering FUJITA Tomonori
2008-02-17 5:53 ` Douglas Gilbert [this message]
2008-02-17 14:10 ` Matthew Wilcox
2008-02-17 14:18 ` James Bottomley
2008-02-17 14:28 ` Matthew Wilcox
2008-02-17 14:52 ` FUJITA Tomonori
2008-02-17 15:02 ` James Bottomley
2008-02-17 15:11 ` FUJITA Tomonori
2008-02-17 15:22 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B7CBC8.2040209@torque.net \
--to=dougg@torque.net \
--cc=James.Bottomley@hansenpartnership.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-scsi@vger.kernel.org \
--cc=tomof@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox