* [PATCH] mvsas: fill in error info record bits
@ 2008-03-05 19:03 Jeff Garzik
2008-03-05 19:28 ` Roel Kluin
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2008-03-05 19:03 UTC (permalink / raw)
To: linux-scsi; +Cc: LKML
This describes the first dword of struct mvs_err_info, two-dword error
information record that is returned when RXQ_ERR bit is asserted.
These bits are necessary for proper error handling.
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
---
diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
index d4a6ac3..ec4dda0 100644
--- a/drivers/scsi/mvsas.c
+++ b/drivers/scsi/mvsas.c
@@ -511,7 +511,35 @@ enum status_buffer {
};
enum error_info_rec {
- CMD_ISS_STPD = (1U << 31), /* Cmd Issue Stopped */
+ CMD_ISS_STPD = (1U << 31), /* Cmd Issue Stopped */
+ CMD_PI_ERR = (1U << 30), /* Protection info error. see flags2 */
+ RSP_OVER = (1U << 29), /* rsp buffer overflow */
+ RETRY_LIM = (1U << 28), /* FIS/frame retry limit exceeded */
+ UNK_FIS = (1U << 27), /* unknown FIS */
+ DMA_TERM = (1U << 26), /* DMA terminate primitive rx'd */
+ SYNC_ERR = (1U << 25), /* SYNC rx'd during frame xmit */
+ TFILE_ERR = (1U << 24), /* SATA taskfile Error bit set */
+ R_ERR = (1U << 23), /* SATA returned R_ERR prim */
+ RD_OFS = (1U << 20), /* Read DATA frame invalid offset *?
+ XFER_RDY_OFS = (1U << 19), /* XFER_RDY offset error */
+ UNEXP_XFER_RDY = (1U << 18), /* unexpected XFER_RDY error */
+ DATA_OVER_UNDER = (1U << 16), /* data overflow/underflow */
+ INTERLOCK = (1U << 15), /* interlock error */
+ NAK = (1U << 14), /* NAK rx'd */
+ ACK_NAK_TO = (1U << 13), /* ACK/NAK timeout */
+ CXN_CLOSED = (1U << 12), /* cxn closed w/out ack/nak */
+ OPEN_TO = (1U << 11), /* I_T nexus lost, open cxn timeout */
+ PATH_BLOCKED = (1U << 10), /* I_T nexus lost, pathway blocked */
+ NO_DEST = (1U << 9), /* I_T nexus lost, no destination */
+ STP_RES_BSY = (1U << 8), /* STP resources busy */
+ BREAK = (1U << 7), /* break received */
+ BAD_DEST = (1U << 6), /* bad destination */
+ BAD_PROTO = (1U << 5), /* protocol not supported */
+ BAD_RATE = (1U << 4), /* cxn rate not supported */
+ WRONG_DEST = (1U << 3), /* wrong destination error */
+ CREDIT_TO = (1U << 2), /* credit timeout */
+ WDOG_TO = (1U << 1), /* watchdog timeout */
+ BUF_PAR = (1U << 0), /* buffer parity error */
};
struct mvs_chip_info {
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mvsas: fill in error info record bits
2008-03-05 19:03 [PATCH] mvsas: fill in error info record bits Jeff Garzik
@ 2008-03-05 19:28 ` Roel Kluin
2008-03-05 19:46 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2008-03-05 19:28 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-scsi, LKML
Jeff Garzik wrote:
> This describes the first dword of struct mvs_err_info, two-dword error
> information record that is returned when RXQ_ERR bit is asserted.
>
> These bits are necessary for proper error handling.
>
> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
> ---
> diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
> index d4a6ac3..ec4dda0 100644
> --- a/drivers/scsi/mvsas.c
> +++ b/drivers/scsi/mvsas.c
> @@ -511,7 +511,35 @@ enum status_buffer {
> };
>
> enum error_info_rec {
> - CMD_ISS_STPD = (1U << 31), /* Cmd Issue Stopped */
> + CMD_ISS_STPD = (1U << 31), /* Cmd Issue Stopped */
> + CMD_PI_ERR = (1U << 30), /* Protection info error. see flags2 */
> + RSP_OVER = (1U << 29), /* rsp buffer overflow */
> + RETRY_LIM = (1U << 28), /* FIS/frame retry limit exceeded */
> + UNK_FIS = (1U << 27), /* unknown FIS */
> + DMA_TERM = (1U << 26), /* DMA terminate primitive rx'd */
> + SYNC_ERR = (1U << 25), /* SYNC rx'd during frame xmit */
> + TFILE_ERR = (1U << 24), /* SATA taskfile Error bit set */
> + R_ERR = (1U << 23), /* SATA returned R_ERR prim */
> + RD_OFS = (1U << 20), /* Read DATA frame invalid offset *?
there is a question mark instead of a slash in the line above.
also I noted 1U << 22 to 1U << 21 were missing. was that intended?
> + XFER_RDY_OFS = (1U << 19), /* XFER_RDY offset error */
> + UNEXP_XFER_RDY = (1U << 18), /* unexpected XFER_RDY error */
> + DATA_OVER_UNDER = (1U << 16), /* data overflow/underflow */
> + INTERLOCK = (1U << 15), /* interlock error */
> + NAK = (1U << 14), /* NAK rx'd */
> + ACK_NAK_TO = (1U << 13), /* ACK/NAK timeout */
> + CXN_CLOSED = (1U << 12), /* cxn closed w/out ack/nak */
> + OPEN_TO = (1U << 11), /* I_T nexus lost, open cxn timeout */
> + PATH_BLOCKED = (1U << 10), /* I_T nexus lost, pathway blocked */
> + NO_DEST = (1U << 9), /* I_T nexus lost, no destination */
> + STP_RES_BSY = (1U << 8), /* STP resources busy */
> + BREAK = (1U << 7), /* break received */
> + BAD_DEST = (1U << 6), /* bad destination */
> + BAD_PROTO = (1U << 5), /* protocol not supported */
> + BAD_RATE = (1U << 4), /* cxn rate not supported */
> + WRONG_DEST = (1U << 3), /* wrong destination error */
> + CREDIT_TO = (1U << 2), /* credit timeout */
> + WDOG_TO = (1U << 1), /* watchdog timeout */
> + BUF_PAR = (1U << 0), /* buffer parity error */
> };
>
> struct mvs_chip_info {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mvsas: fill in error info record bits
2008-03-05 19:28 ` Roel Kluin
@ 2008-03-05 19:46 ` Jeff Garzik
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-03-05 19:46 UTC (permalink / raw)
To: Roel Kluin; +Cc: linux-scsi, LKML
Roel Kluin wrote:
> Jeff Garzik wrote:
>> This describes the first dword of struct mvs_err_info, two-dword error
>> information record that is returned when RXQ_ERR bit is asserted.
>>
>> These bits are necessary for proper error handling.
>>
>> Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
>> ---
>> diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c
>> index d4a6ac3..ec4dda0 100644
>> --- a/drivers/scsi/mvsas.c
>> +++ b/drivers/scsi/mvsas.c
>> @@ -511,7 +511,35 @@ enum status_buffer {
>> };
>>
>> enum error_info_rec {
>> - CMD_ISS_STPD = (1U << 31), /* Cmd Issue Stopped */
>> + CMD_ISS_STPD = (1U << 31), /* Cmd Issue Stopped */
>> + CMD_PI_ERR = (1U << 30), /* Protection info error. see flags2 */
>> + RSP_OVER = (1U << 29), /* rsp buffer overflow */
>> + RETRY_LIM = (1U << 28), /* FIS/frame retry limit exceeded */
>> + UNK_FIS = (1U << 27), /* unknown FIS */
>> + DMA_TERM = (1U << 26), /* DMA terminate primitive rx'd */
>> + SYNC_ERR = (1U << 25), /* SYNC rx'd during frame xmit */
>> + TFILE_ERR = (1U << 24), /* SATA taskfile Error bit set */
>> + R_ERR = (1U << 23), /* SATA returned R_ERR prim */
>> + RD_OFS = (1U << 20), /* Read DATA frame invalid offset *?
>
> there is a question mark instead of a slash in the line above.
definitely a mistake
> also I noted 1U << 22 to 1U << 21 were missing. was that intended?
yes, intended
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-05 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-05 19:03 [PATCH] mvsas: fill in error info record bits Jeff Garzik
2008-03-05 19:28 ` Roel Kluin
2008-03-05 19:46 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).