* [PATCH 0/8] Rework SCSI target allocation
@ 2008-03-18 13:28 Hannes Reinecke
0 siblings, 0 replies; only message in thread
From: Hannes Reinecke @ 2008-03-18 13:28 UTC (permalink / raw)
To: James Bottomley; +Cc: SCSI Mailing List
Hi James,
this is the patchset I talked about at LSF'08. The main idea
here is to align the SCSI target allocation code with the driver
core. For this I've done several things:
- Move all SCSI objects into the SCSI bus: the sysfs 'scsi'
bus now contains all SCSI midlayer objects, equivalent
to the 'usb' bus
- Use default attribute groups for SCSI hosts: with the
all attributes are present when the sysfs dirent is
created; we don't have to wait for them anymore
- Move target cleanup code to the release function.
We only should cleanup the SCSI target structure once
the last reference is gone, hence all cleanup has to
be done from the release function
- Remove reap_ref and sanitize calls to scsi_target_reap:
_Every_ target has at least one sdev connected to it;
once the last sdev is gone the target will be deleted, too.
So we can as well call scsi_target_reap from the release
function of the sdev, hereby ensuring that the target
will _always_ be valid during the lifetime of the sdev.
There is only one driver-related fix:
lpfc and qla2xxx re-use the existing 'state' host attribute
to fill it with some link details. This really is an abuse
IMO as it differs from all other SCSI host attributes.
Hence I've renamed the attribute to 'link_state' to make
it more obvious what's going on. But obviously I'd need
the ACK from the maintainers for this.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-03-18 13:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-18 13:28 [PATCH 0/8] Rework SCSI target allocation Hannes Reinecke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).