From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [SCSI] fix media change events for polled devices Date: Fri, 21 Mar 2008 17:13:06 -0400 Message-ID: <47E424E2.1030801@garzik.org> References: <200803211559.m2LFxPi6017869@hera.kernel.org> <47E3EC67.4050404@garzik.org> <1206128662.2961.37.camel@localhost.localdomain> <47E41C50.4020406@garzik.org> <1206133280.2961.45.camel@localhost.localdomain> <47E422F1.7080806@garzik.org> <1206133787.2961.52.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:54396 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757064AbYCUVNI (ORCPT ); Fri, 21 Mar 2008 17:13:08 -0400 In-Reply-To: <1206133787.2961.52.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Linux Kernel Mailing List , Linus Torvalds , Kay Sievers , Andrew Morton , linux-scsi@vger.kernel.org James Bottomley wrote: > On Fri, 2008-03-21 at 17:04 -0400, Jeff Garzik wrote: >> James Bottomley wrote: >>> It's fixed, and nothing else is additionally broken by the current fix. >> Other than the newly-inconsistent, exported-to-userspace interface, ITYM. > > How is it newly inconsistent? It can still be used in the manner you > intended it, namely to tell if the CD supports AN or not. When we add > the new bit, we'll have to add a new file for it anyway. Previously, the events could be expected to be sent (or sent) in strict accordance with supported_events. Now, you are essentially sending out-of-band events, because the receiver requested supported_events -- but is getting much more than that! You broke a fundamental assumption of the interface -- that supported_events accurately and fully represented all events sent via the new API. Jeff