From: Jeff Garzik <jeff@garzik.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kay Sievers <kay.sievers@vrfy.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi@vger.kernel.org
Subject: Re: [SCSI] fix media change events for polled devices
Date: Fri, 21 Mar 2008 18:35:43 -0400 [thread overview]
Message-ID: <47E4383F.4030804@garzik.org> (raw)
In-Reply-To: <1206136150.2961.79.camel@localhost.localdomain>
James Bottomley wrote:
> Anyway, realistically, since no CD or DVD on the market today seems to
> support the AHCI AN method, this argument is really moot ...
No, it's not. This information is published to userspace EVEN WHEN AN
SUPPORT IS ABSENT. As any sane interface would do -- report a zero value.
Thus, the interface is useful even in the absence of AN.
Anyway, to recap...
before your "fix":
userspace interface always reflected list of events sent
via my new API
after your "fix":
events may or may not be reflected in userspace interface,
who knows?
Is that distinction so difficult to see?
This interface, like it or not, is in 2.6.24, which means its published
and "out there."
This is a clear regression from 2.6.24.
supported_events' value was accurate in 2.6.24. Now it is not.
Jeff
next prev parent reply other threads:[~2008-03-21 22:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200803211559.m2LFxPi6017869@hera.kernel.org>
2008-03-21 17:12 ` [SCSI] fix media change events for polled devices Jeff Garzik
2008-03-21 17:31 ` Linus Torvalds
2008-03-21 19:38 ` James Bottomley
2008-03-21 20:54 ` Jeff Garzik
2008-03-21 20:39 ` Jeff Garzik
2008-03-21 18:33 ` Kay Sievers
2008-03-21 20:42 ` Jeff Garzik
2008-03-21 20:57 ` Kay Sievers
2008-03-21 21:04 ` James Bottomley
2008-03-21 21:10 ` Jeff Garzik
2008-03-21 19:44 ` James Bottomley
2008-03-21 20:36 ` Jeff Garzik
2008-03-21 21:01 ` James Bottomley
2008-03-21 21:04 ` Jeff Garzik
2008-03-21 21:09 ` James Bottomley
2008-03-21 21:13 ` Jeff Garzik
2008-03-21 21:49 ` James Bottomley
2008-03-21 22:35 ` Jeff Garzik [this message]
2008-03-21 22:52 ` James Bottomley
2008-03-25 3:09 ` Jeff Garzik
2008-03-25 3:18 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E4383F.4030804@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox