From: Eric Piel <eric.piel@tremplin-utc.net>
To: linux-scsi@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>
Cc: James.Bottomley@HansenPartnership.com, Tilman Schmidt <tilman@imap.cc>
Subject: What should be done with wrong warning "please use bus_type methods." on sd, sr, st and osst?
Date: Mon, 24 Mar 2008 15:00:45 +0100 [thread overview]
Message-ID: <47E7B40D.1000509@tremplin-utc.net> (raw)
Hello,
Since commit 751bf4d7865e4ced406be93b04c7436d866d3684 (scsi_sysfs:
restore prep_fn when ULD is removed), the warning "Driver '%s' needs
updating - please use bus_type methods." is generated for several scsi
drivers (sr, sg, st and osst). It does so because it thinks that the
driver remove() functions will not be called (cf
__device_release_driver()). Actually, they are called by scsi_bus_remove().
This has been noted already a couple of times [1] [2] [3], but it seems
absolutely nothing conclusive came out of the reports.
What should be done? Delete the warning? Change it so it doesn't get
triggered if drv->bus->remove == scsi_bus_remove? Merge
scsi_bus_remove() into the driver remove() functions? Disregard the
monthly warming reports?
Eric
[1] http://lkml.org/lkml/2008/1/10/47
[2] http://lkml.org/lkml/2008/2/20/547
[3] http://lkml.org/lkml/2008/3/22/198
next reply other threads:[~2008-03-24 14:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-24 14:00 Eric Piel [this message]
2008-03-24 15:24 ` What should be done with wrong warning "please use bus_type methods." on sd, sr, st and osst? James Bottomley
2008-03-24 17:59 ` Greg KH
2008-03-24 18:16 ` James Bottomley
2008-03-25 22:20 ` Éric Piel
2008-03-25 22:34 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E7B40D.1000509@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox