public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Kay Sievers <kay.sievers@vrfy.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-scsi@vger.kernel.org
Subject: Re: [SCSI] fix media change events for polled devices
Date: Mon, 24 Mar 2008 23:09:08 -0400	[thread overview]
Message-ID: <47E86CD4.7040502@garzik.org> (raw)
In-Reply-To: <1206139925.2961.94.camel@localhost.localdomain>

James Bottomley wrote:
> The current published API is the media_events file.  HAL is using that
> to indicate support for AN.  This is why we can't simply change it to 1
> wholesale because we'll confuse HAL (HAL still has to send polling
> events if AN isn't supported).
> 
> So, the best fix for 2.6.25 at the current -rc6 is to keep the meaning
> of the media_change file the same (0 for no AN, 1 for AN) and let HAL
> take the polled events via udev, which basically means it's preserving
> the behaviour and isn't a regression.
> 
> For 2.6.26 we can add a new media_events_polled (or some other name)
> file, fix the sysfs ro attribute and make them true writeable filters so
> some raving user can turn off polled events if they want and everyone
> will be happy.


So version 3 of the interface will be the first stable and usable one... 
sigh :/

It's just disheartening that the userspace filtering stuff (including 
interface) was disabled rather than fixed, given that that change came 
first and arguably the follow-on change (285e9670) was an abuse of the 
API that was never corrected -- which seems to be tacitly acknowledged 
since everyone seems to agree more than one flag is needed.

	Jeff



  reply	other threads:[~2008-03-25  3:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200803211559.m2LFxPi6017869@hera.kernel.org>
2008-03-21 17:12 ` [SCSI] fix media change events for polled devices Jeff Garzik
2008-03-21 17:31   ` Linus Torvalds
2008-03-21 19:38     ` James Bottomley
2008-03-21 20:54       ` Jeff Garzik
2008-03-21 20:39     ` Jeff Garzik
2008-03-21 18:33   ` Kay Sievers
2008-03-21 20:42     ` Jeff Garzik
2008-03-21 20:57       ` Kay Sievers
2008-03-21 21:04       ` James Bottomley
2008-03-21 21:10         ` Jeff Garzik
2008-03-21 19:44   ` James Bottomley
2008-03-21 20:36     ` Jeff Garzik
2008-03-21 21:01       ` James Bottomley
2008-03-21 21:04         ` Jeff Garzik
2008-03-21 21:09           ` James Bottomley
2008-03-21 21:13             ` Jeff Garzik
2008-03-21 21:49               ` James Bottomley
2008-03-21 22:35                 ` Jeff Garzik
2008-03-21 22:52                   ` James Bottomley
2008-03-25  3:09                     ` Jeff Garzik [this message]
2008-03-25  3:18                       ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47E86CD4.7040502@garzik.org \
    --to=jeff@garzik.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox