public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Ke Wei <kewei@marvell.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, jeff@garzik.org, jacky@marvell.com,
	qzhao@marvell.com, qswang@marvell.com
Subject: Re: [PATCH 1/8] mvsas: fill in error info record and phy mode6	bits.
Date: Thu, 27 Mar 2008 15:21:25 +0800	[thread overview]
Message-ID: <47EB4AF5.1070500@marvell.com> (raw)
In-Reply-To: <1206565072.3019.39.camel@localhost.localdomain>

James Bottomley wrote:
> On Fri, 2008-03-21 at 19:00 +0800, Ke Wei wrote:
>> and remove some unused members from struct.
> 
> This patch (and the following ones) look great.  I'm afraid I can't
> apply them, though ... it looks like your mail tool has stripped some
> leading spaces:
> 
>> @@ -37,11 +37,13 @@
>> #include <linux/dma-mapping.h>
>> #include <linux/ctype.h>
>> #include <scsi/libsas.h>
>> +#include <scsi/scsi_tcq.h>
>> +#include <scsi/sas_ata.h>
>> #include <asm/io.h>
> 
> And also added line breaks:
> 
>> +    PHY_MODE6_MUCNT_EN    = (1U << 24),    /* u Count Enable */
>> +    PHY_MODE6_SEL_MUCNT_LEN    = (1U << 22),    /* Training Length
>> Select */
>> +    PHY_MODE6_SELMUPI    = (1U << 20),    /* Phase Multi Select (init) */
> 
> If you need to add the patches as an attachment to get them through your
> mailer undamaged, that's fine ... the tools we have will cope with that.
> 
> Thanks,
> 
> James
> 
> 

Hello James:
	I resended mvsas patch set to community. Thank you for your help. I am moving my email client from Outlook to Thunderbird. So sometimes I need to try some configuration. 
	I have already past mvsas driver testing. By far, look well. If you have any suggestions to help me, pls let me know.


Best regards.
Ke


  reply	other threads:[~2008-03-27  7:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-21 11:00 [PATCH 1/8] mvsas: fill in error info record and phy mode6 bits Ke Wei
2008-03-26 20:57 ` James Bottomley
2008-03-27  7:21   ` Ke Wei [this message]
2008-03-27 15:35     ` James Bottomley
2008-03-27 15:44       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47EB4AF5.1070500@marvell.com \
    --to=kewei@marvell.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=jacky@marvell.com \
    --cc=jeff@garzik.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=qswang@marvell.com \
    --cc=qzhao@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox