From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, marcin.slusarz@gmail.com,
Mark_Salyzyn@adaptec.com
Subject: Re: [patch 05/17] scsi: le*_add_cpu conversion
Date: Fri, 28 Mar 2008 18:09:08 -0400 [thread overview]
Message-ID: <47ED6C84.3070304@garzik.org> (raw)
In-Reply-To: <200803282148.m2SLmZlt012228@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Marcin Slusarz <marcin.slusarz@gmail.com>
>
> replace all:
> little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) +
> expression_in_cpu_byteorder);
> with:
> leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder);
> generated with semantic patch
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: James.Bottomley@HansenPartnership.com
> Acked-by: "Salyzyn, Mark" <Mark_Salyzyn@adaptec.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/scsi/aacraid/commsup.c | 2 +-
> drivers/scsi/ips.c | 8 ++------
> 2 files changed, 3 insertions(+), 7 deletions(-)
Not commenting on the patch, but the API: it should be le32_add() not
le32_add_cpu()
Jeff
prev parent reply other threads:[~2008-03-28 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 21:48 [patch 05/17] scsi: le*_add_cpu conversion akpm
2008-03-28 22:09 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47ED6C84.3070304@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Mark_Salyzyn@adaptec.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox