Re: [PATCH v2 1/4] scsi: ufs: Add checks before setting clk-gating states

Can Guo
2020-07-14T04:12:37Z

Hi Bart,

On 2020-07-14 11:38, Bart Van Assche wrote:
> On 2020-07-13 19:28, Can Guo wrote:
>> @@ -2538,7 +2540,8 @@ static int ufshcd_queuecommand(struct Scsi_Host
>> *host, struct scsi_cmnd *cmd)
>> err = SCSI_MLQUEUE_HOST_BUSY;
>> goto out;
>> }
>> - WARN_ON(hba->clk_gating.state != CLKS_ON);
>> + if (ufshcd_is_clkgating_allowed(hba))
>> + WARN_ON(hba->clk_gating.state != CLKS_ON);
>
> A minor comment: has it been considered to change this into the
> following?
>
> WARN_ON(ufshcd_is_clkgating_allowed(hba) &&
> hba->clk_gating.state != CLKS_ON);
>
> Thanks,
>
> Bart.

Sure, will do that.

Thanks,

Can Guo.