From: Mike Christie <michaelc@cs.wisc.edu>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Jens Axboe <jens.axboe@oracle.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 4/4] iscsi_tcp: Enable large command
Date: Fri, 18 Apr 2008 12:11:13 -0500 [thread overview]
Message-ID: <4808D631.1080507@cs.wisc.edu> (raw)
In-Reply-To: <480237AE.4040101@panasas.com>
Boaz Harrosh wrote:
> Let through up to the largest command of 260 defined by the scsi standard.
> iscsi core supports this already. Now that the scsi-ml supports it we can
> start using large commands.
>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> ---
> drivers/scsi/iscsi_tcp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
> index 555f4e3..6500192 100644
> --- a/drivers/scsi/iscsi_tcp.c
> +++ b/drivers/scsi/iscsi_tcp.c
> @@ -1859,7 +1859,7 @@ iscsi_tcp_session_create(struct Scsi_Host *shost, uint16_t cmds_max,
> shost->max_lun = iscsi_max_lun;
> shost->max_id = 0;
> shost->max_channel = 0;
> - shost->max_cmd_len = 16;
> + shost->max_cmd_len = SCSI_MAX_VARLEN_CDB_SIZE;
> shost->can_queue = cmds_max;
>
> if (iscsi_host_add(shost, NULL))
This is fine whenever all this stuff gets in.
acked-by: Mike Christie <michaelc@cs.wisc.edu>
prev parent reply other threads:[~2008-04-18 17:13 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 16:21 [PATCHSET 0/3] Is it time for varlen extended and vendor-specific cdbs Boaz Harrosh
2008-03-25 16:22 ` [PATCH] Let scsi_cmnd->cmnd use request->cmd buffer Boaz Harrosh
2008-03-25 16:32 ` [PATCH 2/3] block layer varlen-cdb Boaz Harrosh
2008-04-03 16:43 ` James Bottomley
2008-04-03 17:26 ` Benny Halevy
2008-04-03 18:32 ` [PATCH 2/3 ver2] block layer extended-cdb support Boaz Harrosh
2008-04-04 11:46 ` Jens Axboe
2008-04-06 9:35 ` Boaz Harrosh
2008-04-06 11:05 ` Boaz Harrosh
2008-04-07 8:31 ` Jens Axboe
2008-04-12 5:52 ` FUJITA Tomonori
2008-04-13 9:13 ` Boaz Harrosh
2008-04-13 16:17 ` FUJITA Tomonori
2008-04-13 16:50 ` Boaz Harrosh
2008-04-14 9:49 ` [PATCH 2/3 ver3] " Boaz Harrosh
2008-04-14 11:04 ` FUJITA Tomonori
2008-04-14 11:28 ` Boaz Harrosh
2008-04-14 12:08 ` FUJITA Tomonori
2008-04-14 12:22 ` Boaz Harrosh
2008-04-14 11:04 ` [PATCH 2/3 ver2] " FUJITA Tomonori
2008-04-14 10:50 ` [PATCH 0/4] add large command support to the block layer FUJITA Tomonori
2008-04-14 10:50 ` [PATCH 1/4] block: no need to initialize rq->cmd in prepare_flush_fn hook FUJITA Tomonori
2008-04-14 10:50 ` [PATCH 2/4] block: no need to initialize rq->cmd with blk_get_request FUJITA Tomonori
2008-04-14 10:50 ` [PATCH 3/4] block: replace sizeof(rq->cmd) with BLK_MAX_CDB FUJITA Tomonori
2008-04-14 10:50 ` [PATCH 4/4] block: add large command support FUJITA Tomonori
2008-04-14 11:29 ` Jens Axboe
2008-04-14 12:08 ` FUJITA Tomonori
2008-04-15 22:50 ` Bartlomiej Zolnierkiewicz
2008-04-15 22:57 ` FUJITA Tomonori
2008-04-16 0:22 ` Bartlomiej Zolnierkiewicz
2008-04-16 8:33 ` Jens Axboe
2008-04-16 9:08 ` Boaz Harrosh
2008-04-16 9:42 ` Jens Axboe
2008-04-16 22:28 ` Bartlomiej Zolnierkiewicz
2008-04-17 3:59 ` FUJITA Tomonori
2008-04-17 7:07 ` Jens Axboe
2008-04-17 11:55 ` Bartlomiej Zolnierkiewicz
2008-04-17 11:58 ` Bartlomiej Zolnierkiewicz
2008-04-17 12:07 ` FUJITA Tomonori
2008-04-17 4:02 ` FUJITA Tomonori
2008-04-14 14:41 ` Pete Wyckoff
2008-04-14 22:33 ` FUJITA Tomonori
2008-04-15 13:44 ` Pete Wyckoff
2008-04-15 7:45 ` Boaz Harrosh
2008-04-15 10:05 ` FUJITA Tomonori
2008-04-15 7:29 ` Jens Axboe
2008-04-14 11:21 ` [PATCH 0/4] add large command support to the block layer FUJITA Tomonori
2008-04-14 11:38 ` Boaz Harrosh
2008-04-14 12:36 ` Boaz Harrosh
2008-04-14 13:06 ` FUJITA Tomonori
2008-04-15 12:24 ` [PATCH 0/3] scsi: variable-length CDBs support Boaz Harrosh
2008-04-15 12:30 ` [PATCH 1/3] Let scsi_cmnd->cmnd use request->cmd buffer Boaz Harrosh
2008-04-15 12:34 ` [PATCH 2/3] scsi: varlen extended and vendor-specific cdbs Boaz Harrosh
2008-04-16 2:09 ` FUJITA Tomonori
2008-04-16 6:40 ` Boaz Harrosh
2008-04-16 6:49 ` [PATCH 2/3 ver2] " Boaz Harrosh
2008-04-17 4:01 ` [PATCH 2/3] " FUJITA Tomonori
2008-04-17 12:25 ` [PATCH 2/3 ver3] " Boaz Harrosh
2008-04-17 12:49 ` Boaz Harrosh
2008-04-17 13:04 ` FUJITA Tomonori
2008-04-17 13:29 ` Boaz Harrosh
2008-04-15 12:37 ` [PATCH 3/3] iscsi_tcp: Enable large commands Boaz Harrosh
2008-04-15 13:08 ` James Smart
2008-04-15 13:38 ` Boaz Harrosh
2008-04-15 13:57 ` Benny Halevy
2008-04-15 13:46 ` FUJITA Tomonori
2008-04-13 14:07 ` [PATCH 2/3 ver2] block layer extended-cdb support James Bottomley
2008-04-13 16:17 ` FUJITA Tomonori
2008-03-25 16:36 ` [PATCH 3/3] scsi: varlen extended and vendor-specific cdbs Boaz Harrosh
2008-04-03 16:07 ` [PATCHSET 0/3] Is it time for " Boaz Harrosh
2008-04-13 16:30 ` [PATCHSET 0/4 ver2] " Boaz Harrosh
2008-04-13 16:37 ` [PATCH 1/4] Let scsi_cmnd->cmnd use request->cmd buffer Boaz Harrosh
2008-04-13 16:39 ` [PATCH 2/4] block layer extended-cdb support Boaz Harrosh
2008-04-13 16:39 ` [PATCH 3/4] scsi: varlen extended and vendor-specific cdbs Boaz Harrosh
2008-04-13 16:41 ` [PATCH 4/4] iscsi_tcp: Enable large command Boaz Harrosh
2008-04-18 17:11 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4808D631.1080507@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).