From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Subject: Re: [PATCH 4/4] iscsi_tcp: Enable large command Date: Fri, 18 Apr 2008 12:11:13 -0500 Message-ID: <4808D631.1080507@cs.wisc.edu> References: <47E92672.1040208@panasas.com> <48023526.5050709@panasas.com> <480237AE.4040101@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from sabe.cs.wisc.edu ([128.105.6.20]:48132 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755093AbYDRRNV (ORCPT ); Fri, 18 Apr 2008 13:13:21 -0400 In-Reply-To: <480237AE.4040101@panasas.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Boaz Harrosh Cc: James Bottomley , Jens Axboe , linux-scsi , Andrew Morton Boaz Harrosh wrote: > Let through up to the largest command of 260 defined by the scsi standard. > iscsi core supports this already. Now that the scsi-ml supports it we can > start using large commands. > > Signed-off-by: Boaz Harrosh > --- > drivers/scsi/iscsi_tcp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > index 555f4e3..6500192 100644 > --- a/drivers/scsi/iscsi_tcp.c > +++ b/drivers/scsi/iscsi_tcp.c > @@ -1859,7 +1859,7 @@ iscsi_tcp_session_create(struct Scsi_Host *shost, uint16_t cmds_max, > shost->max_lun = iscsi_max_lun; > shost->max_id = 0; > shost->max_channel = 0; > - shost->max_cmd_len = 16; > + shost->max_cmd_len = SCSI_MAX_VARLEN_CDB_SIZE; > shost->can_queue = cmds_max; > > if (iscsi_host_add(shost, NULL)) This is fine whenever all this stuff gets in. acked-by: Mike Christie