* Re: [SCSI] libsas: fix endianness bug in sas_ata
[not found] <200804181917.m3IJHbLk032765@hera.kernel.org>
@ 2008-04-18 20:50 ` Jeff Garzik
0 siblings, 0 replies; only message in thread
From: Jeff Garzik @ 2008-04-18 20:50 UTC (permalink / raw)
To: linux-scsi; +Cc: James Bottomley
Linux Kernel Mailing List wrote:
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -698,7 +698,7 @@ static int sas_discover_sata_dev(struct domain_device *dev)
> /* incomplete response */
> SAS_DPRINTK("sending SET FEATURE/PUP_STBY_SPIN_UP to "
> "dev %llx\n", SAS_ADDR(dev->sas_addr));
> - if (!le16_to_cpu(identify_x[83] & (1<<6)))
> + if (!(identify_x[83] & cpu_to_le16(1<<6)))
> goto cont1;
> res = sas_issue_ata_cmd(dev, ATA_SET_FEATURES,
> ATA_FEATURE_PUP_STBY_SPIN_UP,
Note that this code (not the patch, the code itself) duplicates libata
code performing the same task...
We really need to get libsas going on the new EH. We don't need this
sort of needless code duplication.
Jeff
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-04-18 20:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200804181917.m3IJHbLk032765@hera.kernel.org>
2008-04-18 20:50 ` [SCSI] libsas: fix endianness bug in sas_ata Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).