From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, kewei@marvell.com,
oliver.pntr@gmail.com
Subject: Re: [patch 08/10] drivers/scsi/mvsas.c: fix build warnings
Date: Fri, 18 Apr 2008 17:03:03 -0400 [thread overview]
Message-ID: <48090C87.40504@garzik.org> (raw)
In-Reply-To: <200804182057.m3IKvQtS015394@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> powerpc:
>
> drivers/scsi/mvsas.c: In function 'mvs_update_phyinfo':
> drivers/scsi/mvsas.c:2536: warning: format '%llX' expects type 'long long unsigned int', but argument 5 has type 'u64'
> drivers/scsi/mvsas.c:2536: warning: format '%llX' expects type 'long long unsigned int', but argument 6 has type 'u64'
>
> we do not know what type the architecture uses to implement u64 hence we
> cannot print them directly.
>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Cc: Oliver Pinter <oliver.pntr@gmail.com>
> Cc: Ke Wei <kewei@marvell.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/scsi/mvsas.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff -puN drivers/scsi/mvsas.c~drivers-scsi-mvsasc-fix-build-warnings drivers/scsi/mvsas.c
> --- a/drivers/scsi/mvsas.c~drivers-scsi-mvsasc-fix-build-warnings
> +++ a/drivers/scsi/mvsas.c
> @@ -2822,7 +2822,9 @@ static void mvs_update_phyinfo(struct mv
> dev_printk(KERN_DEBUG, &pdev->dev,
> "phy[%d] Get Attached Address 0x%llX ,"
> " SAS Address 0x%llX\n",
> - i, phy->att_dev_sas_addr, phy->dev_sas_addr);
> + i,
> + (unsigned long long)phy->att_dev_sas_addr,
> + (unsigned long long)phy->dev_sas_addr);
> dev_printk(KERN_DEBUG, &pdev->dev,
Acked-by: Jeff Garzik <jgarzik@redhat.com>
prev parent reply other threads:[~2008-04-18 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 20:57 [patch 08/10] drivers/scsi/mvsas.c: fix build warnings akpm
2008-04-18 21:03 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48090C87.40504@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=kewei@marvell.com \
--cc=linux-scsi@vger.kernel.org \
--cc=oliver.pntr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).