* [patch 08/10] drivers/scsi/mvsas.c: fix build warnings
@ 2008-04-18 20:57 akpm
2008-04-18 21:03 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-04-18 20:57 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-scsi, akpm, jeff, kewei, oliver.pntr
From: Andrew Morton <akpm@linux-foundation.org>
powerpc:
drivers/scsi/mvsas.c: In function 'mvs_update_phyinfo':
drivers/scsi/mvsas.c:2536: warning: format '%llX' expects type 'long long unsigned int', but argument 5 has type 'u64'
drivers/scsi/mvsas.c:2536: warning: format '%llX' expects type 'long long unsigned int', but argument 6 has type 'u64'
we do not know what type the architecture uses to implement u64 hence we
cannot print them directly.
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Oliver Pinter <oliver.pntr@gmail.com>
Cc: Ke Wei <kewei@marvell.com>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/scsi/mvsas.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/scsi/mvsas.c~drivers-scsi-mvsasc-fix-build-warnings drivers/scsi/mvsas.c
--- a/drivers/scsi/mvsas.c~drivers-scsi-mvsasc-fix-build-warnings
+++ a/drivers/scsi/mvsas.c
@@ -2822,7 +2822,9 @@ static void mvs_update_phyinfo(struct mv
dev_printk(KERN_DEBUG, &pdev->dev,
"phy[%d] Get Attached Address 0x%llX ,"
" SAS Address 0x%llX\n",
- i, phy->att_dev_sas_addr, phy->dev_sas_addr);
+ i,
+ (unsigned long long)phy->att_dev_sas_addr,
+ (unsigned long long)phy->dev_sas_addr);
dev_printk(KERN_DEBUG, &pdev->dev,
"Rate = %x , type = %d\n",
sas_phy->linkrate, phy->phy_type);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 08/10] drivers/scsi/mvsas.c: fix build warnings
2008-04-18 20:57 [patch 08/10] drivers/scsi/mvsas.c: fix build warnings akpm
@ 2008-04-18 21:03 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-04-18 21:03 UTC (permalink / raw)
To: akpm; +Cc: James.Bottomley, linux-scsi, kewei, oliver.pntr
akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> powerpc:
>
> drivers/scsi/mvsas.c: In function 'mvs_update_phyinfo':
> drivers/scsi/mvsas.c:2536: warning: format '%llX' expects type 'long long unsigned int', but argument 5 has type 'u64'
> drivers/scsi/mvsas.c:2536: warning: format '%llX' expects type 'long long unsigned int', but argument 6 has type 'u64'
>
> we do not know what type the architecture uses to implement u64 hence we
> cannot print them directly.
>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Cc: Oliver Pinter <oliver.pntr@gmail.com>
> Cc: Ke Wei <kewei@marvell.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/scsi/mvsas.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff -puN drivers/scsi/mvsas.c~drivers-scsi-mvsasc-fix-build-warnings drivers/scsi/mvsas.c
> --- a/drivers/scsi/mvsas.c~drivers-scsi-mvsasc-fix-build-warnings
> +++ a/drivers/scsi/mvsas.c
> @@ -2822,7 +2822,9 @@ static void mvs_update_phyinfo(struct mv
> dev_printk(KERN_DEBUG, &pdev->dev,
> "phy[%d] Get Attached Address 0x%llX ,"
> " SAS Address 0x%llX\n",
> - i, phy->att_dev_sas_addr, phy->dev_sas_addr);
> + i,
> + (unsigned long long)phy->att_dev_sas_addr,
> + (unsigned long long)phy->dev_sas_addr);
> dev_printk(KERN_DEBUG, &pdev->dev,
Acked-by: Jeff Garzik <jgarzik@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-04-18 21:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-18 20:57 [patch 08/10] drivers/scsi/mvsas.c: fix build warnings akpm
2008-04-18 21:03 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).