Re: [GIT PATCH] another tranche of SCSI updates for 2.6.26

James Bottomley
2008-04-28T18:25:38Z

On Mon, 2008-04-28 at 09:05 -0700, Linus Torvalds wrote:
>
> On Sun, 27 Apr 2008, James Bottomley wrote:
> >
> > Try this; the signature for an uninitialised free list is easy (both
> > list pointers NULL), so the patch detects that and doesn't try to run
> > over the uninitialised list head.
>
> Why aren't these things initialized?

They are, but not until we begin the freelist allocation. That way we
can keep the list head being NULL as the signal for the freelist not
being initialised.

> You say that the signature of an uninitialised free list is trivial, but
> that's not at all true in general. It depends intimately on how the memory
> was allocated, and is thus very subtle indeed - some change to allocations
> can break something simple like this, by initializing it with random old
> memory contents.

No, no; for us it's guaranteed to be NULL ... they're allocated in the
host memory area with kzalloc. (and before kzalloc, we were using
kmalloc/memset because the host area has an API guarantee of being zero
initialised).

> So why not just initialize lists like this so early (ie at allocation
> time) that problems like this cannot happen? Instead of adding ugly and
> fragile cases to the freeing?

Because then I'd need another flag to know whether or not the free list
has actually been set up. In theory, if we initialise the list,
list_empty() would do because when you're freeing you should always have
the reserve command on the free list ... but that would have prevented
us from seeing the bug Ingo reported recently (where we were freeing
with active commands), so I'm a bit reluctant to do that.

James