From: Mike Christie <michaelc@cs.wisc.edu>
To: David C Somayajulu <david.somayajulu@qlogic.com>
Cc: linux-scsi@vger.kernel.org, David Wagner <david.wagner@qlogic.com>
Subject: Re: [PATCH]qla4xxx:Add support for Async Message PDUs [REPOST with fixes]
Date: Wed, 30 Apr 2008 14:36:45 -0500 [thread overview]
Message-ID: <4818CA4D.3040204@cs.wisc.edu> (raw)
In-Reply-To: <4818C721.9090701@cs.wisc.edu>
Mike Christie wrote:
> David C Somayajulu wrote:
>> + }
>> + if (sshdr.asc == 0x3f && sshdr.ascq == 0x0e) {
>> + /* induce rescan */
>> + iscsi_block_session(ddb_entry->sess);
>> + iscsi_unblock_session(ddb_entry->sess);
>> + }
>
> I think I was wrong off list. We could actually just call
> iscsi_unblock_session, but we do not know the state of the session do
> we? If we got a event that indicated the session was failed could we
> have a block queued up and this would reverse it by accident?
>
> I was thinking that because qla4xxx_process_aen is called before this we
> could just check the ddb state, but we can call iscsi_block_session from
> the interrupt handler to queue up a block so I think that could race
> with the unblock call here.
Maybe to handle the race we do not want to call qla4xxx_mark_device_busy
when we get SCS_TIMEOUT. If we get a ddb aen then could we just wait for
that and all those events would be serialized through the dpc thread?
What does SCS_TIMEOUT mean?
next prev parent reply other threads:[~2008-04-30 19:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 20:44 [PATCH]qla4xxx:Add support for Async Message PDUs David C Somayajulu
2008-04-22 16:20 ` Mike Christie
2008-04-24 16:01 ` David C Somayajulu
2008-04-24 16:40 ` Mike Christie
2008-04-24 19:42 ` David C Somayajulu
2008-04-25 19:23 ` David C Somayajulu
2008-04-26 16:42 ` Mike Christie
2008-04-28 15:39 ` David C Somayajulu
2008-04-30 18:35 ` [PATCH]qla4xxx:Add support for Async Message PDUs [REPOST with fixes] David C Somayajulu
2008-04-30 19:23 ` Mike Christie
2008-04-30 19:36 ` Mike Christie [this message]
2008-05-01 0:36 ` David C Somayajulu
2008-05-01 14:59 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4818CA4D.3040204@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=david.somayajulu@qlogic.com \
--cc=david.wagner@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).