Re: On patch "Let scsi_cmnd->cmnd use request->cmd buffer"

Boaz Harrosh
2008-05-04T12:16:30Z

Stefan Richter wrote:
> Commit 64a87b244b9297667ca80264aab849a36f494884 contains:
> -------------------------- drivers/firewire/fw-sbp2.c --------------------------
> index 2a99937..dda82f3 100644
> @@ -1487,7 +1487,7 @@ static int sbp2_scsi_queuecommand(struct scsi_cmnd *cmd, scsi_done_fn_t done)
> if (scsi_sg_count(cmd) && sbp2_map_scatterlist(orb, device, lu) < 0)
> goto out;
>
> - memcpy(orb->request.command_block, cmd->cmnd, COMMAND_SIZE(*cmd->cmnd));
> + memcpy(orb->request.command_block, cmd->cmnd, cmd->cmd_len);
>
> orb->base.callback = complete_command_orb;
> orb->base.request_bus =
>
>
> Should drivers/ieee1394/sbp2.c::sbp2_create_command_orb() be changed in
> the same way?
>
Sorry to have missed it. Yes it is best if it is changed. cmd->cmd_len
is now guarantied to be set
properly at all cases. And some commands you want to support will not be
set correctly by
COMMAND_SIZE(). do you want me to do it?

Boaz