From: Erez Zilber <erezz@Voltaire.COM>
To: Pete Wyckoff <pw@osc.edu>, Roland Dreier <rolandd@cisco.com>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/3] iscsi iser: increase max_sectors
Date: Mon, 05 May 2008 16:36:42 +0300 [thread overview]
Message-ID: <481F0D6A.9050301@Voltaire.COM> (raw)
In-Reply-To: <20080212205420.GD13643@osc.edu>
Pete Wyckoff wrote:
> iser has no limit on max sectors. This lets iscsi iser support
> large pass through commands just like iscsi TCP.
>
> Signed-off-by: Pete Wyckoff <pw@osc.edu>
> ---
> drivers/infiniband/ulp/iser/iscsi_iser.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
> index 1b272a6..78f3242 100644
> --- a/drivers/infiniband/ulp/iser/iscsi_iser.c
> +++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
> @@ -557,7 +557,7 @@ static struct scsi_host_template iscsi_iser_sht = {
> .change_queue_depth = iscsi_change_queue_depth,
> .can_queue = ISCSI_DEF_XMIT_CMDS_MAX - 1,
> .sg_tablesize = ISCSI_ISER_SG_TABLESIZE,
> - .max_sectors = 1024,
> + .max_sectors = 0xffff,
>
This could be problematic because, AFAIK, some HCAs (memfree, I think)
don't support FMRs of more than 2MB. Roland, am I right?
next prev parent reply other threads:[~2008-05-05 13:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 20:52 [PATCH 0/3] iscsi iser limits Pete Wyckoff
2008-02-12 20:54 ` [PATCH 1/3] iscsi iser: remove DMA restrictions Pete Wyckoff
2008-02-12 21:10 ` James Bottomley
2008-02-12 21:46 ` Pete Wyckoff
2008-02-12 21:57 ` James Bottomley
2008-02-13 19:59 ` Pete Wyckoff
2008-02-14 21:10 ` [PATCH 1/3 v2] iscsi iser: remove DMA alignment restriction Pete Wyckoff
2008-05-05 13:19 ` Erez Zilber
2008-04-21 13:51 ` [PATCH 1/3] iscsi iser: remove DMA restrictions Erez Zilber
2008-04-23 13:41 ` [ofa-general] " Erez Zilber
2008-04-23 16:33 ` Mike Christie
2008-04-23 17:16 ` Mike Christie
2008-04-23 17:43 ` Mike Christie
2008-02-14 17:56 ` Mike Christie
2008-02-14 18:10 ` James Bottomley
2008-02-14 18:21 ` Mike Christie
2008-02-14 18:34 ` Mike Christie
2008-02-14 19:04 ` Mike Christie
2008-02-12 20:54 ` [PATCH 2/3] iscsi iser: increase max_sectors Pete Wyckoff
2008-05-05 13:36 ` Erez Zilber [this message]
2008-05-05 20:43 ` Roland Dreier
2008-05-05 17:49 ` Mike Christie
2008-05-07 15:53 ` Pete Wyckoff
2008-05-12 12:10 ` Erez Zilber
2008-02-12 20:54 ` [PATCH 3/3] iscsi iser: increase sg_tablesize Pete Wyckoff
2008-03-02 13:56 ` [PATCH 0/3] iscsi iser limits Erez Zilber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481F0D6A.9050301@Voltaire.COM \
--to=erezz@voltaire.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=pw@osc.edu \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).