From: Mike Christie <michaelc@cs.wisc.edu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 4/8] scsi: use get_unaligned_* helpers
Date: Mon, 05 May 2008 13:46:16 -0500 [thread overview]
Message-ID: <481F55F8.1040606@cs.wisc.edu> (raw)
In-Reply-To: <1209700376.22362.19.camel@brick>
Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> drivers/scsi/libiscsi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
> index 010c1b9..7646e86 100644
> --- a/drivers/scsi/libiscsi.c
> +++ b/drivers/scsi/libiscsi.c
> @@ -508,7 +508,7 @@ invalid_datalen:
> goto out;
> }
>
> - senselen = be16_to_cpu(get_unaligned((__be16 *) data));
> + senselen = get_unaligned_be16(data);
> if (datalen < senselen)
> goto invalid_datalen;
>
This looks ok. Thanks.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
If It does not get picked up by Andrew then I will send it with the
other iscsi updates when the next feature window opens.
prev parent reply other threads:[~2008-05-05 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-02 3:52 [PATCH 4/8] scsi: use get_unaligned_* helpers Harvey Harrison
2008-05-05 18:46 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481F55F8.1040606@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).