From: Hannes Reinecke <hare@suse.de>
To: sekharan@us.ibm.com
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-scsi@vger.kernel.org, dm-devel <dm-devel@redhat.com>
Subject: Re: [PATCH 4/7] scsi_dh: Update EMC handler
Date: Thu, 15 May 2008 10:09:16 +0200 [thread overview]
Message-ID: <482BEFAC.7030400@suse.de> (raw)
In-Reply-To: <1210819629.21974.255.camel@chandra-ubuntu>
Hi Chandra,
Chandra Seetharaman wrote:
> On Wed, 2008-05-14 at 16:43 +0200, Hannes Reinecke wrote:
> <snip>
>
>> @@ -438,10 +604,32 @@ static int clariion_bus_attach(struct scsi_device *sdev)
>> sdev->scsi_dh_data = scsi_dh_data;
>> spin_unlock_irqrestore(sdev->request_queue->queue_lock, flags);
>>
> Can move the block above to be just before try_module_get() and avoid
> undoing it in the failed path.
>
Hmm. Yes, we could. But that means I have to pass the scsi_dh_data structure
to basically every function.
Let me check how this pans out.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-05-15 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 14:43 [PATCH 4/7] scsi_dh: Update EMC handler Hannes Reinecke
2008-05-15 2:47 ` Chandra Seetharaman
2008-05-15 8:09 ` Hannes Reinecke [this message]
2008-05-16 18:38 ` Chandra Seetharaman
-- strict thread matches above, loose matches on Subject: below --
2008-05-20 14:05 Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482BEFAC.7030400@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sekharan@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox