From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [Re: Linux 2.6.26-rc2] Write protect on on Date: Mon, 19 May 2008 20:45:14 +0300 Message-ID: <4831BCAA.8040509@panasas.com> References: <4831A60A.5010308@panasas.com> <4831B2E2.8030700@panasas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from gw-colo-pa.panasas.com ([66.238.117.130]:19731 "EHLO cassoulet.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756075AbYESRpt (ORCPT ); Mon, 19 May 2008 13:45:49 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Linus Torvalds Cc: Alan Stern , Maciej Rutecki , Linux Kernel Mailing List , USB list , USB Storage list , SCSI development list Linus Torvalds wrote: > > On Mon, 19 May 2008, Boaz Harrosh wrote: >> Sure, inspecting other places that emulate MODE_SENSE, (And inspecting the scsi >> spec) all zeros is a very good scsi response. Alan do you want to send a fix for all >> places that initiate a MODE_SENSE command, specifically at >> scsi_scan.c::scsi_unlock_floptical() ? (Some other places do) > > I was actualyl more thinking that the safest thing to do would be to just > pre-clear the sense buffer. Then, if some driver doesn't fill it > correctly, big deal.. The sense buffer *is* always cleared and it is mandated by scsi spec. But the problem above is that the actual data buffer for read, had garbage data, and *no* read was actually preformed do to none-standard device response. > > It's not like pre-clearing the bugger is a performance issue. > > Linus > -- Boaz