From: Brian King <brking@linux.vnet.ibm.com>
To: michael@ellerman.id.au
Cc: Dave Boutcher <boutcher@cs.umn.edu>,
linuxppc-dev@ozlabs.org,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/1] ibmvscsi: Non SCSI error status fixup
Date: Tue, 20 May 2008 08:52:36 -0500 [thread overview]
Message-ID: <4832D7A4.1070609@linux.vnet.ibm.com> (raw)
In-Reply-To: <1211245688.12970.0.camel@localhost>
Michael Ellerman wrote:
> On Mon, 2008-05-19 at 10:56 -0500, Dave Boutcher wrote:
>> On Mon, 19 May 2008 10:27:56 -0500, Brian King <brking@linux.vnet.ibm.com> said:
>>> Some versions of the Virtual I/O Server on Power
>>> return 0x99 in the non-SCSI error status field as success,
>>> rather than 0. This fixes the ibmvscsi driver to treat this
>>> response as success.
>> Yeah....0x99...that's an intuitive value for success.
>
> Hopefully there are no versions that return 0x99 for an error? :)
There shouldn't be. 0x99 is actually not defined as a valid value for
that field, but it is what the ibmvscsis VIOS that is included in
SLES 9 and SLES 10 return on success, due to a bug in that driver.
We plan to fix the ibmvscsis driver as well, but it will take a while
for that fix to propagate. Until very recently, the status field was not
checked, which is why we are only recently running into this problem.
-Brian
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
next parent reply other threads:[~2008-05-20 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <12112108763801-patch-mail.ibm.com>
[not found] ` <18481.41759.969242.972595@gargle.gargle.HOWL>
[not found] ` <1211245688.12970.0.camel@localhost>
2008-05-20 13:52 ` Brian King [this message]
2008-05-19 15:27 [PATCH 1/1] ibmvscsi: Non SCSI error status fixup Brian King
-- strict thread matches above, loose matches on Subject: below --
2008-05-19 15:27 Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4832D7A4.1070609@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=boutcher@cs.umn.edu \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).