public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: John Garry <john.garry@huawei.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>
Subject: Re: [PATCH v2 01/44] ips: Use true and false instead of TRUE and FALSE
Date: Tue, 8 Feb 2022 16:04:27 -0800	[thread overview]
Message-ID: <483bf415-8a13-0d2c-8737-9322c19ba537@acm.org> (raw)
In-Reply-To: <deb3fd22-2352-097f-7fa0-20d2e338aac8@huawei.com>

On 2/8/22 10:04, John Garry wrote:
> On 08/02/2022 17:24, Bart Van Assche wrote:
>> diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
>> index 498bf04499ce..b3532d290848 100644
>> --- a/drivers/scsi/ips.c
>> +++ b/drivers/scsi/ips.c
>> @@ -655,13 +655,13 @@ ips_release(struct Scsi_Host *sh)
> 
> This function and other places return an int, and not a bool, so that 
> could be changed as well. Prob not worth the churn, though.

Because of this comment I took a closer look at the ips_release() 
function. It seems to me that that function only has one caller and that 
caller ignores the value returned by ips_release(). So how about 
changing the return type into 'void'?

Thanks,

Bart.

  reply	other threads:[~2022-02-09  0:04 UTC|newest]

Thread overview: 168+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 17:24 [PATCH v2 00/44] Remove the SCSI pointer from struct scsi_cmnd Bart Van Assche
2022-02-08 17:24 ` [PATCH v2 01/44] ips: Use true and false instead of TRUE and FALSE Bart Van Assche
2022-02-08 18:04   ` John Garry
2022-02-09  0:04     ` Bart Van Assche [this message]
2022-02-09  9:06       ` John Garry
2022-02-08 20:00   ` Himanshu Madhani
2022-02-09  7:23   ` Hannes Reinecke
2022-02-08 17:24 ` [PATCH v2 02/44] nsp_cs: " Bart Van Assche
2022-02-08 19:22   ` Himanshu Madhani
2022-02-09  7:23   ` Hannes Reinecke
2022-02-09  9:11   ` John Garry
2022-02-08 17:24 ` [PATCH v2 03/44] scsi: Remove drivers/scsi/scsi.h Bart Van Assche
2022-02-08 19:22   ` Himanshu Madhani
2022-02-09  7:26   ` Hannes Reinecke
2022-02-09 17:39     ` Bart Van Assche
2022-02-09  8:55   ` Johannes Thumshirn
2022-02-09  9:17   ` John Garry
2022-02-09 18:21     ` John Garry
2022-02-08 17:24 ` [PATCH v2 04/44] NCR5380: Remove the NCR5380_CMD_SIZE macro Bart Van Assche
2022-02-08 19:22   ` Himanshu Madhani
2022-02-08 22:14   ` Finn Thain
2022-02-09  7:27   ` Hannes Reinecke
2022-02-08 17:24 ` [PATCH v2 05/44] NCR5380: Move the SCSI pointer to private command data Bart Van Assche
2022-02-08 19:48   ` Himanshu Madhani
2022-02-08 22:22   ` Finn Thain
2022-02-09  0:10     ` Bart Van Assche
2022-02-09  7:29   ` Hannes Reinecke
2022-02-09 17:58     ` Bart Van Assche
2022-02-08 17:24 ` [PATCH v2 06/44] scsi: arm: Rename arm/scsi.h into arm/arm_scsi.h Bart Van Assche
2022-02-08 19:49   ` Himanshu Madhani
2022-02-09  7:30   ` Hannes Reinecke
2022-02-08 17:24 ` [PATCH v2 07/44] scsi: arm: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09  7:32   ` Hannes Reinecke
2022-02-09 17:49   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 08/44] 53c700: Stop clearing SCSI pointer fields Bart Van Assche
2022-02-08 19:58   ` Himanshu Madhani
2022-02-09  7:32   ` Hannes Reinecke
2022-02-08 17:24 ` [PATCH v2 09/44] aacraid: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09  7:34   ` Hannes Reinecke
2022-02-09 17:47   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 10/44] advansys: " Bart Van Assche
2022-02-08 17:24 ` [PATCH v2 11/44] aha1542: Remove a set-but-not-used array Bart Van Assche
2022-02-09  7:35   ` Hannes Reinecke
2022-02-09 17:50   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 12/44] aha152x: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09  7:35   ` Hannes Reinecke
2022-02-09 17:57   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 13/44] bfa: Stop using the SCSI pointer Bart Van Assche
2022-02-09  7:40   ` Hannes Reinecke
2022-02-09 18:19     ` Bart Van Assche
2022-02-10  7:29       ` Hannes Reinecke
2022-02-09 18:00   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 14/44] csio: " Bart Van Assche
2022-02-09  7:41   ` Hannes Reinecke
2022-02-09 18:03   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 15/44] dc395x: " Bart Van Assche
2022-02-09  7:42   ` Hannes Reinecke
2022-02-09 18:03   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 16/44] esp_scsi: " Bart Van Assche
2022-02-09  7:45   ` Hannes Reinecke
2022-02-09 18:04   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 17/44] fdomain: Move the SCSI pointer to private command data Bart Van Assche
2022-02-08 20:35   ` Himanshu Madhani
2022-02-09  7:46   ` Hannes Reinecke
2022-02-08 17:24 ` [PATCH v2 18/44] fnic: Fix a tracing statement Bart Van Assche
2022-02-09  7:46   ` Hannes Reinecke
2022-02-09 18:05   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 19/44] fnic: Stop using the SCSI pointer Bart Van Assche
2022-02-09  7:56   ` Hannes Reinecke
2022-02-09 18:22     ` Bart Van Assche
2022-02-10  7:30       ` Hannes Reinecke
2022-02-09 18:17   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 20/44] hptiop: " Bart Van Assche
2022-02-09  7:57   ` Hannes Reinecke
2022-02-09 18:24     ` Bart Van Assche
2022-02-10  7:32       ` Hannes Reinecke
2022-02-09 18:18   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 21/44] imm: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09  7:58   ` Hannes Reinecke
2022-02-09 18:27     ` Bart Van Assche
2022-02-10  7:42       ` Hannes Reinecke
2022-02-10 23:54         ` Bart Van Assche
2022-02-09 18:19   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 22/44] iscsi: Stop using the SCSI pointer Bart Van Assche
2022-02-09  7:59   ` Hannes Reinecke
2022-02-09 18:22   ` Himanshu Madhani
2022-02-09 19:55   ` Lee Duncan
2022-02-09 21:24   ` Mike Christie
2022-02-09 23:35     ` Chris Leech
2022-02-10  1:21     ` Bart Van Assche
2022-02-09 23:37   ` Chris Leech
2022-02-10  1:26     ` Bart Van Assche
2022-02-08 17:24 ` [PATCH v2 23/44] initio: " Bart Van Assche
2022-02-09  8:04   ` Hannes Reinecke
2022-02-09 18:24   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 24/44] libfc: " Bart Van Assche
2022-02-09  8:10   ` Hannes Reinecke
2022-02-09 18:33     ` Bart Van Assche
2022-02-09 18:28   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 25/44] mac53c94: Fix a set-but-not-used compiler warning Bart Van Assche
2022-02-09  8:10   ` Hannes Reinecke
2022-02-09 18:33   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 26/44] mac53c94: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09  8:11   ` Hannes Reinecke
2022-02-09 18:35     ` Bart Van Assche
2022-02-10  7:52       ` Hannes Reinecke
2022-02-09 18:37   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 27/44] megaraid: Stop using the SCSI pointer Bart Van Assche
2022-02-09  8:14   ` Hannes Reinecke
2022-02-09 18:38     ` Bart Van Assche
2022-02-09 18:39   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 28/44] megasas: " Bart Van Assche
2022-02-09  8:16   ` Hannes Reinecke
2022-02-09 18:45   ` Himanshu Madhani
2022-02-08 17:24 ` [PATCH v2 29/44] mesh: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09  8:49   ` Hannes Reinecke
2022-02-09 18:42   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 30/44] mvsas: Fix a set-but-not-used warning Bart Van Assche
2022-02-08 17:50   ` John Garry
2022-02-09  0:19     ` Bart Van Assche
2022-02-09  8:49   ` Hannes Reinecke
2022-02-09 18:43   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 31/44] mvumi: Stop using the SCSI pointer Bart Van Assche
2022-02-09  8:18   ` Hannes Reinecke
2022-02-09 18:46   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 32/44] nsp32: " Bart Van Assche
2022-02-09  8:18   ` Hannes Reinecke
2022-02-09  8:19   ` Hannes Reinecke
2022-02-09 18:48   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 33/44] nsp_cs: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09  8:20   ` Hannes Reinecke
2022-02-09 18:50   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 34/44] sym53c500_cs: " Bart Van Assche
2022-02-09  8:21   ` Hannes Reinecke
2022-02-09 18:56   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 35/44] ppa: " Bart Van Assche
2022-02-09  8:22   ` Hannes Reinecke
2022-02-09 18:56   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 36/44] qla1280: " Bart Van Assche
2022-02-09  8:22   ` Hannes Reinecke
2022-02-09 18:58   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 37/44] qla2xxx: Stop using the SCSI pointer Bart Van Assche
2022-02-08 18:38   ` Himanshu Madhani
2022-02-09  8:24   ` Hannes Reinecke
2022-02-09 10:11   ` Daniel Wagner
2022-02-08 17:25 ` [PATCH v2 38/44] smartpqi: " Bart Van Assche
2022-02-09  8:33   ` Hannes Reinecke
2022-02-09 18:59   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 39/44] sym53c8xx_2: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09  8:34   ` Hannes Reinecke
2022-02-09 19:10   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 40/44] scsi: usb: Stop using the SCSI pointer Bart Van Assche
2022-02-09  8:35   ` Hannes Reinecke
2022-02-09 19:01   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 41/44] wd719x: " Bart Van Assche
2022-02-09  8:35   ` Hannes Reinecke
2022-02-09 19:04   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 42/44] wdc33c93: Move the SCSI pointer to private command data Bart Van Assche
2022-02-09  8:36   ` Hannes Reinecke
2022-02-09 19:10   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 43/44] zalon: Stop using the SCSI pointer Bart Van Assche
2022-02-09  8:36   ` Hannes Reinecke
2022-02-09 19:11   ` Himanshu Madhani
2022-02-08 17:25 ` [PATCH v2 44/44] scsi: core: Remove struct scsi_pointer from struct scsi_cmnd Bart Van Assche
2022-02-08 17:54   ` John Garry
2022-02-09  0:24     ` Bart Van Assche
2022-02-08 19:22   ` Himanshu Madhani
2022-02-09  8:38   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483bf415-8a13-0d2c-8737-9322c19ba537@acm.org \
    --to=bvanassche@acm.org \
    --cc=aacraid@microsemi.com \
    --cc=jejb@linux.ibm.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=john.garry@huawei.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox