From: Douglas Gilbert <dougg@torque.net>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/1] sg: Add target reset support
Date: Tue, 01 Jul 2008 21:41:16 -0400 [thread overview]
Message-ID: <486ADCBC.3020608@torque.net> (raw)
In-Reply-To: <200807011803.m61I3OoD030274@d01av02.pok.ibm.com>
Brian King wrote:
> Adds support for target reset to SG_SCSI_RESET.
>
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
> ---
>
> drivers/scsi/sg.c | 3 +++
> include/scsi/sg.h | 1 +
> 2 files changed, 4 insertions(+)
>
> diff -puN drivers/scsi/sg.c~sg_target_reset drivers/scsi/sg.c
> --- linux-2.6/drivers/scsi/sg.c~sg_target_reset 2008-06-16 15:34:16.000000000 -0500
> +++ linux-2.6-bjking1/drivers/scsi/sg.c 2008-06-16 15:36:48.000000000 -0500
> @@ -1026,6 +1026,9 @@ sg_ioctl(struct inode *inode, struct fil
> case SG_SCSI_RESET_DEVICE:
> val = SCSI_TRY_RESET_DEVICE;
> break;
> + case SG_SCSI_RESET_TARGET:
> + val = SCSI_TRY_RESET_TARGET;
> + break;
> case SG_SCSI_RESET_BUS:
> val = SCSI_TRY_RESET_BUS;
> break;
> diff -puN include/scsi/sg.h~sg_target_reset include/scsi/sg.h
> --- linux-2.6/include/scsi/sg.h~sg_target_reset 2008-06-16 15:36:05.000000000 -0500
> +++ linux-2.6-bjking1/include/scsi/sg.h 2008-06-16 15:36:17.000000000 -0500
> @@ -206,6 +206,7 @@ typedef struct sg_req_info { /* used by
> #define SG_SCSI_RESET_DEVICE 1
> #define SG_SCSI_RESET_BUS 2
> #define SG_SCSI_RESET_HOST 3
> +#define SG_SCSI_RESET_TARGET 4
>
> /* synchronous SCSI command ioctl, (only in version 3 interface) */
> #define SG_IO 0x2285 /* similar effect as write() followed by read() */
> _
>
Brian,
Is SG_SCSI_RESET_DEVICE actually a Logical Unit Reset
(as defined by SAM-4) on a modern LLD? If so perhaps a
comment could be added to sg.h as "DEVICE" is an
overused word.
Signed-off-by: Douglas Gilbert <dougg@torque.net>
next prev parent reply other threads:[~2008-07-02 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 18:03 [PATCH 1/1] sg: Add target reset support Brian King
2008-07-02 1:41 ` Douglas Gilbert [this message]
2008-07-03 16:15 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486ADCBC.3020608@torque.net \
--to=dougg@torque.net \
--cc=James.Bottomley@HansenPartnership.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).