From: Hannes Reinecke <hare@suse.de>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/3] aic7xxx: debloat
Date: Wed, 02 Jul 2008 11:17:28 +0200 [thread overview]
Message-ID: <486B47A8.3090809@suse.de> (raw)
In-Reply-To: <200807011848.22599.vda.linux@googlemail.com>
Hi Denys,
Denys Vlasenko wrote:
> Hi Hannes,
>
> aic7xxx still contains ~30kb of dead code if pretty printing of registers
> is requested. These patches deal with it.
>
> I did not get any feedback from you whether the approach of adding
> "dont_generate_debug_code" marker would be acceptable despite
> asking twice. I decided that it's a "Yes".
>
Well, yes. Sort of.
Patches are okay in principle, only it would be best if you could hook
the dont_generate_debug_code marker to the AIC79XX_DEBUG_ENABLE config option.
This way anyone interested in doing sequencer debugging would still get
the full sequencer code (which can be quite helpful at times).
And it would be disabled for the unsuspecting user.
Apart from this: well done.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-07-02 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 16:48 [PATCH 0/3] aic7xxx: debloat Denys Vlasenko
2008-07-01 16:50 ` [PATCH 1/3] aic7xxx: introduce "dont_generate_debug_code" keyword in aicasm parser Denys Vlasenko
2008-07-01 16:52 ` [PATCH 2/3] aic7xxx: update .reg files Denys Vlasenko
2008-07-01 16:54 ` [PATCH 3/3] aic7xxx: update *_shipped files Denys Vlasenko
2008-07-01 17:02 ` [PATCH 2/3] aic7xxx: update .reg files Denys Vlasenko
2008-07-02 9:17 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486B47A8.3090809@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).