From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Howells <dhowells@redhat.com>,
alan@redhat.com, Markus.Lidel@shadowconnect.com, vvs@sw.ru,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Mark i2o config broken on 64-bit platforms.
Date: Wed, 09 Jul 2008 11:46:58 -0400 [thread overview]
Message-ID: <4874DD72.2050903@garzik.org> (raw)
In-Reply-To: <20080709154753.3dcfacab@the-village.bc.nu>
Alan Cox wrote:
> On Wed, 09 Jul 2008 12:35:47 +0100
> David Howells <dhowells@redhat.com> wrote:
>
>> Mark i2o config broken on 64-bit platforms as it generates these:
>>
>> In file included from drivers/message/i2o/config-osm.c:39:
>> drivers/message/i2o/i2o_config.c: In function 'i2o_cfg_passthru':
>> drivers/message/i2o/i2o_config.c:889: warning: cast to pointer from integer of different size
>> drivers/message/i2o/i2o_config.c:945: warning: cast to pointer from integer of different size
>>
>> which are apparently non-trivial to fix (eg: inserting a cast through unsigned
>> long is not correct according to Linus). This would be due to struct
>> sg_simple_element only having a 32-bit addr_bus value.
>>
>> There are also a number of "TODO 64bit fix" comments.
>>
>> Signed-off-by: David Howells <dhowells@redhat.com>
>
>
> NAK - it appears to be broken for 64bit user space only
Agreed.
That was the conclusion when I joined the cast of thousands who tried to
kill this warning, and found that out...
Jeff
prev parent reply other threads:[~2008-07-09 15:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 11:35 [PATCH] Mark i2o config broken on 64-bit platforms David Howells
2008-07-09 11:47 ` Andrew Morton
2008-07-09 12:07 ` David Howells
2008-07-09 13:47 ` Miquel van Smoorenburg
2008-07-09 14:15 ` David Howells
2008-07-09 15:08 ` Bernd Petrovitsch
2008-07-09 15:49 ` Alan Cox
2008-07-09 16:42 ` David Howells
2008-07-09 19:06 ` Miquel van Smoorenburg
2008-07-09 19:13 ` James Bottomley
2008-07-09 19:22 ` Miquel van Smoorenburg
2008-07-09 19:59 ` James Bottomley
2008-07-09 20:06 ` Miquel van Smoorenburg
2008-07-10 11:13 ` Alan Cox
2008-07-10 12:12 ` David Howells
2008-07-10 14:53 ` Alan Cox
2008-07-10 15:23 ` Alan Cox
2008-07-09 18:49 ` Miquel van Smoorenburg
2008-07-10 11:45 ` Alan Cox
2008-07-09 14:46 ` Alan Cox
2008-07-09 16:18 ` David Howells
2008-07-09 14:47 ` Alan Cox
2008-07-09 15:46 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4874DD72.2050903@garzik.org \
--to=jeff@garzik.org \
--cc=Markus.Lidel@shadowconnect.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox