From: Subhash Jadavani <subhashj@codeaurora.org>
To: kusumi.tomohiro@gmail.com
Cc: martin.petersen@oracle.com, vinholikatti@gmail.com,
linux-scsi@vger.kernel.org, Tomohiro Kusumi <tkusumi@tuxera.com>,
linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH 2/6] scsi: ufs: use existing macro CONTROLLER_ENABLE to test register bit
Date: Tue, 28 Mar 2017 22:02:53 -0700 [thread overview]
Message-ID: <4876fb0f3b1539f140d29c8af6e06c52@codeaurora.org> (raw)
In-Reply-To: <20170328134929.25599-2-tkusumi@tuxera.com>
On 2017-03-28 06:49, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> (Note this commit directly goes on top of the previous one)
>
> Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index b006f1e..dd46259 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -836,7 +836,8 @@ static inline void ufshcd_hba_start(struct ufs_hba
> *hba)
> */
> static inline bool ufshcd_is_hba_active(struct ufs_hba *hba)
> {
> - return (ufshcd_readl(hba, REG_CONTROLLER_ENABLE) & 0x1) ? false :
> true;
> + return (ufshcd_readl(hba, REG_CONTROLLER_ENABLE) & CONTROLLER_ENABLE)
> + ? false : true;
> }
>
> static const char *ufschd_uic_link_state_to_string(
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-03-29 5:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 13:49 [PATCH 1/6] scsi: ufs: make ufshcd_is_{device_present,hba_active}() return bool kusumi.tomohiro
2017-03-28 13:49 ` [PATCH 2/6] scsi: ufs: use existing macro CONTROLLER_ENABLE to test register bit kusumi.tomohiro
2017-03-29 5:02 ` Subhash Jadavani [this message]
2017-03-28 13:49 ` [PATCH 3/6] scsi: ufs: non functional macro fix kusumi.tomohiro
2017-03-29 5:03 ` Subhash Jadavani
2017-03-28 13:49 ` [PATCH 4/6] scsi: ufs: add missing macros for register bits from UFSHCI spec kusumi.tomohiro
2017-03-29 5:04 ` Subhash Jadavani
2017-03-28 13:49 ` [PATCH 5/6] scsi: ufs: remove deprecated enum for hw interrupt kusumi.tomohiro
2017-03-29 5:07 ` Subhash Jadavani
2017-03-28 13:49 ` [PATCH 6/6] scsi: ufs: just use sizeof() for snprintf() kusumi.tomohiro
2017-03-29 5:08 ` Subhash Jadavani
2017-03-29 4:59 ` [PATCH 1/6] scsi: ufs: make ufshcd_is_{device_present,hba_active}() return bool Subhash Jadavani
2017-03-30 2:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4876fb0f3b1539f140d29c8af6e06c52@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=kusumi.tomohiro@gmail.com \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tkusumi@tuxera.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).