From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 1/1] 3ware add MSI support Date: Wed, 23 Jul 2008 14:59:00 +0300 Message-ID: <48871D04.8070601@panasas.com> References: <20080723014745.GH7337@parisc-linux.org> <1216813629.3557.3.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from gw-colo-pa.panasas.com ([66.238.117.130]:3094 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751666AbYGWL7Y (ORCPT ); Wed, 23 Jul 2008 07:59:24 -0400 In-Reply-To: <1216813629.3557.3.camel@localhost.localdomain> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: Matthew Wilcox , adam radford , linux-scsi , linux-pci@vger.kernel.org James Bottomley wrote: > On Tue, 2008-07-22 at 19:47 -0600, Matthew Wilcox wrote: >> On Tue, Jul 22, 2008 at 04:36:32PM -0700, adam radford wrote: >>> This patch for the 3w-9xxx scsi driver applies on top of the >>> BKL-pushdown changes in -git9. >>> >>> This patch does the following: >>> >>> - Increase max AENs drained to 256. >>> - Add MSI support and "use_msi" module parameter. >>> - Fix bug in twa_get_param() on 4GB+. >>> - Use pci_resource_len() for ioremap(). >> Is there a reason you default use_msi to off? I would have thought >> you'd want to enable it as widely as possible. > > Hardly ... just look at our LSI fiasco with globally enabling them. > > Right at the moment, due to motherboard bugs, it looks like global > enabling of MSI by default would produce a significant increase in "my > system doesn't boot" type bugs. > > I asked Jesse if we could actually get better recognition of > motherboards with MSI problems in pci/quirks.c to forestall some of > this, but it seems to be a hard problem. I've cc'd the PCI list in case > they have better suggestions. > > James > This seems to be a general problem. Maybe there should be an LSI_SYSTEM_DEFAULT kind of parameter or function, that will enable LSI if it is default for the system on all supporting drivers. This way a user can configure LSI=on for all drivers in one place instead of configuring each driver individually. Boaz