Re: [PATCH #upstream-fixes] libata: Add transport class for libata

Matthew Wilcox
2008-08-19T12:27:38Z

On Tue, Aug 19, 2008 at 01:34:04PM +0200, Stefan Richter wrote:
> Gwendal Grignou wrote:
> > This patch adds objects for accessing libata objects from user space:
> > - ata_port class: one per ATA port
> > - ata_link class: one per ATA port or 15 for SATA Port Multiplier
> > - ata_device class: up to 2 for PATA link, usually one for SATA.
>
> Two outsider questions:
>
> You are adding a userspace interface. What are the stability commitments?

To channel GregKH, you need to document them in Documentation/ABI/

> Could you make it configurable, so that people who don't need this
> interface can build the kernel without it?

Please, no. Don't we already have enough CONFIG options?

I think a more important question is ... this is coming from a Google
address, but has a Copyright Dell on it. Where's the sign-off chain for
this? Who's the author really?

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."