Re: [PATCH #upstream-fixes] libata: Add transport class for libata

Stefan Richter
2008-08-19T13:41:01Z

I wrote:
>>> Gwendal Grignou wrote:
>>>> + count = 0;
>>>> + SETUP_PORT_ATTRIBUTE(nr_pmp_links);
>>>> + SETUP_PORT_ATTRIBUTE(idle_irq);
>>>> + BUG_ON(count > ATA_PORT_ATTRS);
>>>> + i->port_attrs[count] = NULL;
>
> I understand that such preprocessor games are hard to avoid in code like
> sysfs attribute setup. I have nothing better to suggest, but they are
> ugly nevertheless, and may amount to bloat.
>
> Anyway; the BUG_ON there should probably be a BUILD_BUG_ON.

...but alas gcc isn't clever enough: It won't report if ATA_PORT_ATTRS
was too small.
--
Stefan Richter
-=====-==--- =--- =--==