From: Mike Christie <michaelc@cs.wisc.edu>
To: James Smart <James.Smart@Emulex.Com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: fc class: terminate callback fixes
Date: Tue, 19 Aug 2008 18:46:44 -0500 [thread overview]
Message-ID: <48AB5B64.9010604@cs.wisc.edu> (raw)
In-Reply-To: <48AAE8A2.2090702@emulex.com>
James Smart wrote:
> Yep - I just sent the ack...
>
Ok. I will rediff for the current scsi-misc and fix up the bit setting
and resend.
Thanks.
> Thanks
>
> -- james s
>
> Mike Christie wrote:
>> michaelc@cs.wisc.edu wrote:
>>> This fixes the problems discussed in this thread:
>>> http://marc.info/?l=linux-scsi&m=121573444523292&w=2
>>> where we need to call scsi_target_unblock in the code
>>> path where the terminate call back is used. The unblock calls is
>>> need so that IO does not get stuck when removing the rport. And for
>>> the fast IO fail case, I merged the patch to fast fail
>>> IO so it does not bounce around between the queue
>>> and driver and is returned to the upper layer quickly.
>>> These patch then solve all the issues and fix the problem
>>> for drivers that were not implementing the callback.
>>>
>>> The patches were made over scsi-misc and the qlogic update
>>> in that thread.
>>>
>>
>> Hey JamesS,
>>
>> Are these patches ok?
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-08-19 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-12 2:40 fc class: terminate callback fixes michaelc
2008-07-12 2:40 ` [PATCH 1/2] fc class: unblock target after calling terminate callback michaelc
2008-07-12 2:40 ` [PATCH 2/2] fc drivers: remove scsi_target_unblock calls in terminate callbacks michaelc
2008-08-17 20:54 ` fc class: terminate callback fixes Mike Christie
2008-08-19 15:37 ` James Smart
2008-08-19 23:46 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AB5B64.9010604@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Smart@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).