From: James Smart <James.Smart@Emulex.Com>
To: Seokmann Ju <seokmann.ju@qlogic.com>
Cc: Robert W Love <robert.w.love@intel.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
Boaz Harrosh <bharrosh@panasas.com>,
Mike Christie <michaelc@cs.wisc.edu>
Subject: Re: [RFC] pass through support in fc transport: via bsg (block SG)
Date: Fri, 22 Aug 2008 17:53:11 -0400 [thread overview]
Message-ID: <48AF3547.4040703@emulex.com> (raw)
In-Reply-To: <7773BCE2-99A3-467D-B7AF-C182F2773A9C@qlogic.com>
Nope - not forgotten, just a lot of different things to get to.
I don't know of anything in the header that needs to be specified.
Everything is either fixed because it is an ELS/CT request, or what
needs to be specified (usually S_ID/D_ID) comes from the object the bsg
reference is to. CS_CTL is the only one that is a maybe - but that's a
whole different story, and we should just ignore it for now. So I'm
against a header.
Additionally, we have to be careful about what kind of interface we
believe the LLD's support. If they expected a raw frame transmit, I
don't know how many support that, especially as adapters very much
control XID's, etc. Create Exchange, w/ Send/Receive, sequence is
prefered, but even that might be too low. At best, there is explicit
els or ct assist interfaces - which means the LLD/adapter is likely
handling all the header and segmentation, and the interface is just
passing payload buffers.
So in general it's a request, w/ xmt payload, buffer for response, and a
completion status (which I would assume is more than just an int and a
couple of #defines - we have to cover the F_RJT/P_RJT/ABORT cases..)
-- james s
Seokmann Ju wrote:
> I just want to re-stroke this thread to make sure it is not skipped.
>
> One question came to me while testing qla2xxx module with the changes.
> When the application issues ELS/CT packet, should the packet include
> the FC frame header?
> And if the answer is 'yes', should the driver also include the FC
> frame header when it returns response to the application (just like
> any other frame exchanges in between two ports on the FC)?
> The FC frame header has type field that identifies what type of the
> payload (ELS / CT / etc.) the frame contains and the type field is
> being checked by the FC transport layer before it calls LLDD's handler.
>
> Thank you,
> Seokmann
next prev parent reply other threads:[~2008-08-22 21:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 19:04 [RFC] pass through support in fc transport: via bsg (block SG) Seokmann Ju
2008-08-19 17:42 ` Seokmann Ju
2008-08-22 21:36 ` Seokmann Ju
2008-08-22 21:53 ` James Smart [this message]
2008-08-22 22:09 ` Andrew Vasquez
2008-08-22 22:35 ` Chris Leech
2008-08-22 22:48 ` Andrew Vasquez
2008-08-23 14:43 ` James Smart
2008-09-11 13:25 ` Seokmann Ju
2008-09-11 13:44 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AF3547.4040703@emulex.com \
--to=james.smart@emulex.com \
--cc=andrew.vasquez@qlogic.com \
--cc=bharrosh@panasas.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=robert.w.love@intel.com \
--cc=seokmann.ju@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox