Re: qlogicpti driver hangs the machine

[Boaz Harrosh <bharrosh@panasas.com>]

David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 23 Sep 2008 21:53:02 -0700 (PDT)
> 
>> I'm about to stick a qlogicpti card into my ultra2 and try to reproduce
>> this.
> 
> Unfortunately, the driver works just fine for me, in fact it's
> checking the root filesystem right now :-)
> 
> Meelis, if Matthew isn't able to give you some debugging patches or
> other stuff to try, I'll try to get this fixed when I get back from
> the netfilter workshop in Paris in 2 weeks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Subject: [PATCH] fix fall out of sg-chaining patch

I've reviewed all patches since Matthew's, and I find one small
problem.

In the load_cmd() there is a compound loop where the first 4 sg's are
set then the rest are set into a memory structure in group of 7 sg's.

Well the second 7-group and on is a bug because sg pointer does not advance.
This is a fall out from Jens's patch.

I'm not sure if this is it but it should be fixed
---
git diff --stat -p
 drivers/scsi/qlogicpti.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c
index 4a1cf63..9053508 100644
--- a/drivers/scsi/qlogicpti.c
+++ b/drivers/scsi/qlogicpti.c
@@ -914,6 +914,7 @@ static inline int load_cmd(struct scsi_cmnd *Cmnd, struct Command_Entry *cmd,
 				ds[i].d_count = sg_dma_len(s);
 			}
 			sg_count -= n;
+			sg = s;
 		}
 	} else {
 		cmd->dataseg[0].d_base = 0;