From: Boaz Harrosh <bharrosh@panasas.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org,
Sam Creasey <sammy@sammy.net>,
Michael Schmitz <schmitz@biophys.uni-duesseldorf.de>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: mac scsi, ncr5380
Date: Thu, 02 Oct 2008 11:33:42 +0300 [thread overview]
Message-ID: <48E48766.4010903@panasas.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0810011703120.13318@loopy.telegraphics.com.au>
Finn Thain wrote:
>
> On Sun, 28 Sep 2008, Boaz Harrosh wrote:
>
>> From what I understand, (And again I do not), the ESP sounds a lot like
>> the NCR5380. I would craft a very similar copy of the new ESP stack,
>> with it's central library and function-vector registration, The
>> scsi-generic part is all there, in full glory. Then one concentrated
>> effort should go into the basic/general chip programing, which lots of
>> it could be ripped from current code, and the different platform
>> implementation becomes one liners, if the new ESP stack is any
>> indication.
>
> I still do not understand the whole ESP driver but when I wrote mac_esp.c
> I learned the value of the layered structure it provided.
>
> I still have a lot to learn about the SCSI layers and the APIs too. I'm
> reading Documentation/scsi at the moment. If you know of any other
> introductory reading material, that would be a help.
>
I don't know anything about the ESP driver, You should contact
David S. Miller, Perhaps he will have some time to help you.
The SCSI-API I know more about. Please don't hesitate to ask
any question, I will be glad to answer.
>> From my passed experience, there becomes a source code state when a
>> rewrite is less effort then any cleanup or enhancements. From the small
>> changes I had to do to the xxx_NCR5380 family of drivers, my guts
>> feeling scream "rewrite", so here I voice them. In the mid/long-term you
>> will work much less. And be much more satisfied from the results.
>
> This makes sense. Thanks for your feedback.
>
> Finn
>
>> Good lock
>> Boaz
>> --
Thanks for looking into this. We are here for any assistance
Boaz
prev parent reply other threads:[~2008-10-02 8:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-26 8:27 mac scsi, ncr5380 Finn Thain
2008-09-26 14:40 ` [linux-m68k] " Sam Creasey
2008-09-27 3:10 ` Michael Schmitz
2008-09-27 8:00 ` Finn Thain
2008-09-27 19:12 ` Brad Boyer
2008-09-28 11:28 ` Finn Thain
2008-09-28 18:03 ` Brad Boyer
2008-09-29 13:22 ` Finn Thain
2008-09-29 23:18 ` Brad Boyer
2008-09-30 8:40 ` Finn Thain
2008-09-29 21:03 ` Riccardo
2008-09-30 6:18 ` Finn Thain
2008-09-28 13:16 ` Boaz Harrosh
2008-09-30 8:45 ` Christoph Hellwig
2008-10-01 8:04 ` Finn Thain
2008-10-01 7:19 ` Finn Thain
2008-10-02 8:33 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E48766.4010903@panasas.com \
--to=bharrosh@panasas.com \
--cc=fthain@telegraphics.com.au \
--cc=hch@infradead.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sammy@sammy.net \
--cc=schmitz@biophys.uni-duesseldorf.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox