public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: thomas schorpp <thomas.schorpp@googlemail.com>
To: SCSI development list <linux-scsi@vger.kernel.org>
Subject: [PATCH]aic7xxx: Take the LED out of diagnostic mode on PM resume, too.
Date: Fri, 03 Oct 2008 23:45:29 +0200	[thread overview]
Message-ID: <48E69279.2000507@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

Take the Diag/Activity-LED of the HBA out of diagnostic mode on PM resume after successful PM resume from standby and HBA restart, 
it remained always on before. If something fails before complete recovery, it should remain on, since it is a diagnostics LED, 
reason for the used higher layer for the clear. 

Signed-off-by: thomas.schorpp@gmail.com




[-- Attachment #2: aic7xxx_PM_fixled.patch --]
[-- Type: text/x-diff, Size: 542 bytes --]

--- drivers/scsi/aic7xxx/aic7xxx_core.c	2008-10-03 13:53:39.000000000 +0200
+++ drivers/scsi/aic7xxx/aic7xxx_core.c	2008-10-03 14:26:04.000000000 +0200
@@ -814,6 +814,7 @@
 static void
 ahc_restart(struct ahc_softc *ahc)
 {
+	uint8_t	sblkctl;
 
 	ahc_pause(ahc);
 
@@ -868,6 +869,12 @@
 	ahc_outb(ahc, SEQADDR0, 0);
 	ahc_outb(ahc, SEQADDR1, 0);
 
+	/*
+	 * Take the LED out of diagnostic mode on PM resume, too
+	 */
+	sblkctl = ahc_inb(ahc, SBLKCTL);
+	ahc_outb(ahc, SBLKCTL, (sblkctl & ~(DIAGLEDEN|DIAGLEDON)));
+
 	ahc_unpause(ahc);
 }
 

                 reply	other threads:[~2008-10-03 21:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48E69279.2000507@gmail.com \
    --to=thomas.schorpp@googlemail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=thomas.schorpp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox