From: Randy Dunlap <randy.dunlap@oracle.com>
To: scsi <linux-scsi@vger.kernel.org>, akpm <akpm@linux-foundation.org>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
Achim Leubner <achim_leubner@adaptec.com>
Subject: [PATCH] gdth: fix section mismatch warnings
Date: Wed, 08 Oct 2008 14:24:48 -0700 [thread overview]
Message-ID: <48ED2520.1080203@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
Could fix a bug in a hotplug scenario.
WARNING: drivers/scsi/gdth.o(.text+0x3e6d): Section mismatch in reference from the function gdth_pci_probe_one() to the function .init.text:gdth_search_drives()
The function gdth_pci_probe_one() references
the function __init gdth_search_drives().
This is often because gdth_pci_probe_one lacks a __init
annotation or the annotation of gdth_search_drives is wrong.
WARNING: drivers/scsi/gdth.o(.text+0x3f78): Section mismatch in reference from the function gdth_pci_probe_one() to the function .init.text:gdth_enable_int()
The function gdth_pci_probe_one() references
the function __init gdth_enable_int().
This is often because gdth_pci_probe_one lacks a __init
annotation or the annotation of gdth_enable_int is wrong.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Achim Leubner <achim_leubner@adaptec.com>
---
drivers/scsi/gdth.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- lin2627-r9g1-sections.orig/drivers/scsi/gdth.c
+++ lin2627-r9g1-sections/drivers/scsi/gdth.c
@@ -1238,7 +1238,7 @@ static int gdth_init_pci(struct pci_dev
/* controller protocol functions */
-static void __init gdth_enable_int(gdth_ha_str *ha)
+static void gdth_enable_int(gdth_ha_str *ha)
{
ulong flags;
gdt2_dpram_str __iomem *dp2_ptr;
@@ -1554,7 +1554,7 @@ static int gdth_internal_cmd(gdth_ha_str
/* search for devices */
-static int __init gdth_search_drives(gdth_ha_str *ha)
+static int gdth_search_drives(gdth_ha_str *ha)
{
ushort cdev_cnt, i;
int ok;
@@ -4919,7 +4919,7 @@ static int __init gdth_eisa_probe_one(us
#endif /* CONFIG_EISA */
#ifdef CONFIG_PCI
-static int gdth_pci_probe_one(gdth_pci_str *pcistr,
+int gdth_pci_probe_one(gdth_pci_str *pcistr,
gdth_ha_str **ha_out)
{
struct Scsi_Host *shp;
reply other threads:[~2008-10-08 21:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ED2520.1080203@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=achim_leubner@adaptec.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox