From: Boaz Harrosh <bharrosh@panasas.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: "James Bottomley" <James.Bottomley@hansenpartnership.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jörn Engel" <joern@logfs.org>,
"open-osd development" <osd-dev@open-osd.org>,
"Mike Christie" <michaelc@cs.wisc.edu>,
"FUJITA Tomonori" <fujita.tomonori@lab.ntt.co.jp>,
"Jeff Garzik" <jeff@garzik.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Sami.Iren@seagate.com,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/18 ver3] libosd: OSDv1 Headers
Date: Thu, 13 Nov 2008 11:38:43 +0200 [thread overview]
Message-ID: <491BF5A3.9070700@panasas.com> (raw)
In-Reply-To: <20081112105945.f4ec0089.randy.dunlap@oracle.com>
Randy Dunlap wrote:
>
> ugh
>
>> + } __packed attrs_cdb;
>> +/*52*/ u8 get_set_attributes_parameters[80-52];
>
> ugh
>
>
> more of the same
>
>
> ditto. nice comment ;)
>
>
>
> Thanks for the fixes.
>
Yes Yes that was version 3 where I was asking if I might convince you
for its merits.
As I said in that reply I will change it. Just did not have the chance
to send out version 4 out yet.
Thanks
Boaz
next prev parent reply other threads:[~2008-11-13 9:38 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48876009.8010701@panasas.com>
2008-07-24 17:30 ` [RFC 00/14] open-osd: OSD Initiator library for Linux Boaz Harrosh
2008-07-24 17:40 ` [RFC 01/14] libosd: OSDv1 Headers Boaz Harrosh
2008-07-24 17:45 ` [RFC 02/14] libosd: OSDv1 preliminary implementation Boaz Harrosh
2008-07-24 17:47 ` [RFC 03/14] osd_uld: OSD scsi ULD Boaz Harrosh
2008-07-27 21:16 ` James Bottomley
2008-08-06 17:25 ` Boaz Harrosh
2008-07-24 17:49 ` [RFC 04/14] osd_ktests: Add basic OSD tests Boaz Harrosh
2008-07-24 17:51 ` [RFC 05/14] libosd: attributes Support Boaz Harrosh
2008-07-24 17:53 ` [RFC 06/14] osd_ktests: Test Attribute lists Boaz Harrosh
2008-07-24 17:54 ` [RFC 07/14] libosd: OSD Security processing stubs Boaz Harrosh
2008-07-24 17:55 ` [RFC 08/14] libosd: Add Flush and List-objects support Boaz Harrosh
2008-07-24 17:57 ` [RFC 09/14] libosd: Not implemented commands Boaz Harrosh
2008-07-24 17:58 ` [RFC 10/14] libosd: OSD version 2 Support Boaz Harrosh
2008-07-24 17:59 ` [RFC 11/14] osd_ktests: OSDv2 auto detection Boaz Harrosh
2008-07-24 18:00 ` [RFC 12/14] osd: Kconfig file for in-tree builds Boaz Harrosh
2008-07-24 18:02 ` [RFC 13/14] osd: Documentation for OSD library Boaz Harrosh
2008-07-24 18:03 ` [RFC 14/14] scsi: Add osd library to build system Boaz Harrosh
2008-11-04 16:09 ` [PATCHSET 00/18] open-osd: OSD Initiator library for Linux Boaz Harrosh
2008-11-04 16:17 ` [PATCH 01/18] major.h: char-major number for OSD device driver Boaz Harrosh
2008-11-26 17:33 ` [osd-dev] " Boaz Harrosh
2008-11-26 18:07 ` Randy Dunlap
2008-11-04 16:42 ` [PATCH 02/18] scsi: OSD_TYPE Boaz Harrosh
2008-11-04 16:44 ` [PATCH 03/18] libosd: OSDv1 Headers Boaz Harrosh
2008-11-04 19:10 ` Andrew Morton
2008-11-04 19:42 ` Jörn Engel
2008-11-04 20:29 ` Jörn Engel
2008-11-05 13:00 ` Boaz Harrosh
2008-11-05 12:54 ` Boaz Harrosh
2008-11-05 13:09 ` James Bottomley
2008-11-05 13:29 ` Boaz Harrosh
2008-11-09 14:52 ` [PATCH 03/18 ver2] " Boaz Harrosh
2008-11-09 17:45 ` Jörn Engel
2008-11-10 8:47 ` Boaz Harrosh
2008-11-10 15:17 ` Jörn Engel
2008-11-10 17:29 ` Randy Dunlap
2008-11-12 13:10 ` Boaz Harrosh
2008-11-12 16:48 ` Randy Dunlap
2008-11-12 17:09 ` Boaz Harrosh
2008-11-12 17:15 ` Johannes Berg
2008-11-12 13:13 ` [PATCH 03/18 ver3] " Boaz Harrosh
2008-11-12 18:59 ` Randy Dunlap
2008-11-13 9:38 ` Boaz Harrosh [this message]
2008-11-13 12:25 ` [PATCH 03/18 ver4] " Boaz Harrosh
2008-11-13 18:16 ` Randy Dunlap
2008-11-13 15:41 ` [osd-dev] " Benny Halevy
2008-11-04 16:44 ` [PATCH 04/18] libosd: OSDv1 preliminary implementation Boaz Harrosh
2008-11-04 16:44 ` [PATCH 05/18] osd_uld: OSD scsi ULD Boaz Harrosh
2008-11-04 16:44 ` [PATCH 06/18] osd_uld: API for retrieving osd devices from Kernel Boaz Harrosh
2008-11-04 16:44 ` [PATCH 07/18] osd_test: User-mode application to run the OSD tests Boaz Harrosh
2008-11-04 16:44 ` [PATCH 08/18] osd_ktests: Add basic " Boaz Harrosh
2008-11-04 16:44 ` [PATCH 09/18] libosd: attributes Support Boaz Harrosh
2008-11-04 16:44 ` [PATCH 10/18] osd_ktests: Test Attribute lists Boaz Harrosh
2008-11-04 16:44 ` [PATCH 11/18] libosd: OSD Security processing stubs Boaz Harrosh
2008-11-04 16:44 ` [PATCH 12/18] libosd: Add Flush and List-objects support Boaz Harrosh
2008-11-04 16:44 ` [PATCH 13/18] libosd: Not implemented commands Boaz Harrosh
2008-11-04 16:44 ` [PATCH 14/18] libosd: OSD version 2 Support Boaz Harrosh
2008-11-04 16:44 ` [PATCH 15/18] libosd: OSDv2 auto detection Boaz Harrosh
2008-11-04 16:44 ` [PATCH 16/18] osd: Documentation for OSD library Boaz Harrosh
2008-11-04 16:44 ` [PATCH 17/18] osd: Kconfig file for in-tree builds Boaz Harrosh
2008-11-04 16:44 ` [PATCH 18/18] scsi: Add osd library to build system Boaz Harrosh
2008-11-04 19:19 ` [PATCHSET 00/18] open-osd: OSD Initiator library for Linux Andrew Morton
2008-11-05 13:56 ` Boaz Harrosh
2008-11-09 14:58 ` Boaz Harrosh
2008-11-09 23:26 ` Stephen Rothwell
2008-11-10 12:52 ` Boaz Harrosh
2008-11-10 13:04 ` Stephen Rothwell
[not found] ` <1225817069-5969-1-git-send-email-bharrosh@panasas.com>
2008-11-04 18:03 ` [PATCH 04/18] libosd: OSDv1 preliminary implementation Sam Ravnborg
2008-11-05 13:12 ` Boaz Harrosh
2008-11-09 14:55 ` [osd-dev] " Boaz Harrosh
2008-11-10 5:37 ` Randy Dunlap
2008-11-10 9:00 ` Boaz Harrosh
2008-11-04 19:16 ` Andrew Morton
2008-11-05 13:44 ` Boaz Harrosh
2008-11-09 14:50 ` [PATCH 04/18 ver2] " Boaz Harrosh
2008-12-22 12:32 ` [PATCHSET 00/18] open-osd: OSD Initiator library for Linux Boaz Harrosh
2008-12-22 12:37 ` [PATCH 01/18] major.h: char-major number for OSD device driver Boaz Harrosh
2008-12-22 12:39 ` [PATCH 02/18] scsi: OSD_TYPE Boaz Harrosh
2008-12-22 12:41 ` [PATCH 03/18] libosd: OSDv1 Headers Boaz Harrosh
2008-12-22 12:43 ` [PATCH 04/18] libosd: OSDv1 preliminary implementation Boaz Harrosh
2008-12-22 12:46 ` [PATCH 05/18] osd_uld: OSD scsi ULD Boaz Harrosh
2008-12-22 12:49 ` [PATCH 06/18] osd_uld: API for retrieving osd devices from Kernel Boaz Harrosh
2008-12-22 12:51 ` [PATCH 07/18] osd_ktests: Add basic OSD tests Boaz Harrosh
2008-12-22 12:55 ` [PATCH 08/18] libosd: attributes Support Boaz Harrosh
2008-12-22 12:57 ` [PATCH 09/18] osd_ktests: Test Attribute lists Boaz Harrosh
2008-12-22 13:00 ` [PATCH 10/18] libosd: OSD Security processing stubs Boaz Harrosh
2008-12-22 13:02 ` [PATCH 11/18] libosd: Add Flush and List-objects support Boaz Harrosh
2008-12-22 13:04 ` [PATCH 12/18] libosd: Not implemented commands Boaz Harrosh
2008-12-22 13:07 ` [PATCH 13/18] libosd: OSD version 2 Support Boaz Harrosh
2008-12-22 13:09 ` [PATCH 14/18] libosd: OSDv2 auto detection Boaz Harrosh
2008-12-22 13:13 ` [PATCH 15/18] libosd: SCSI/OSD Sense decoding support Boaz Harrosh
2008-12-22 13:16 ` [PATCH 16/18] osd: Documentation for OSD library Boaz Harrosh
2008-12-22 13:18 ` [PATCH 17/18] osd: Kconfig file for in-tree builds Boaz Harrosh
2008-12-22 13:20 ` [PATCH 18/18] scsi: Add osd library to build system Boaz Harrosh
2009-01-06 14:04 ` [PATCHSET 00/18] open-osd: OSD Initiator library for 2.6.29 Boaz Harrosh
2009-01-06 14:07 ` [PATCH 01/18] major.h: char-major number for OSD device driver Boaz Harrosh
2009-01-06 14:10 ` [PATCH 02/18] scsi: OSD_TYPE Boaz Harrosh
2009-01-06 14:11 ` [PATCH 03/18] libosd: OSDv1 Headers Boaz Harrosh
2009-01-06 14:13 ` [PATCH 04/18] libosd: OSDv1 preliminary implementation Boaz Harrosh
2009-01-06 14:14 ` [PATCH 05/18] osd_uld: OSD scsi ULD Boaz Harrosh
2009-01-06 16:47 ` [PATCH ver2 05/16] " Boaz Harrosh
2009-01-06 14:16 ` [PATCH 06/18] osd_uld: API for retrieving osd devices from Kernel Boaz Harrosh
2009-01-06 14:17 ` [PATCH 07/18] osd_ktests: Add basic OSD tests Boaz Harrosh
2009-01-06 14:42 ` FUJITA Tomonori
2009-01-06 14:56 ` Boaz Harrosh
2009-01-06 15:12 ` FUJITA Tomonori
2009-01-06 15:49 ` Boaz Harrosh
2009-01-06 16:58 ` FUJITA Tomonori
2009-01-06 17:04 ` Boaz Harrosh
2009-01-06 16:49 ` Boaz Harrosh
2009-01-06 14:19 ` [PATCH 08/18] libosd: attributes Support Boaz Harrosh
2009-01-06 14:20 ` [PATCH 09/18] osd_ktests: Test Attribute lists Boaz Harrosh
2009-01-06 16:50 ` Boaz Harrosh
2009-01-06 14:21 ` [PATCH 10/18] libosd: OSD Security processing stubs Boaz Harrosh
2009-01-06 14:23 ` [PATCH 11/18] libosd: Add Flush and List-objects support Boaz Harrosh
2009-01-06 14:24 ` [PATCH 12/18] libosd: Not implemented commands Boaz Harrosh
2009-01-06 14:25 ` [PATCH 13/18] libosd: OSD version 2 Support Boaz Harrosh
2009-01-06 14:27 ` [PATCH 14/18] libosd: OSDv2 auto detection Boaz Harrosh
2009-01-06 14:29 ` [PATCH 15/18] libosd: SCSI/OSD Sense decoding support Boaz Harrosh
2009-01-06 14:31 ` [PATCH 16/18] osd: Documentation for OSD library Boaz Harrosh
2009-01-06 14:32 ` [PATCH 17/18] osd: Kconfig file for in-tree builds Boaz Harrosh
2009-01-06 17:40 ` Randy Dunlap
2009-01-07 8:48 ` Boaz Harrosh
2009-01-07 17:10 ` Randy Dunlap
2009-01-07 8:53 ` [PATCH ver2 15/16] " Boaz Harrosh
2009-01-06 14:34 ` [PATCH 18/18] scsi: Add osd library to build system Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491BF5A3.9070700@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Sami.Iren@seagate.com \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jeff@garzik.org \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=osd-dev@open-osd.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).