Re: [RFC] FC pass thru - Rev V

FUJITA Tomonori
2009-03-19T01:57:30Z

On Sun, 15 Mar 2009 11:34:59 +0200
Boaz Harrosh <bharrosh@panasas.com> wrote:

> Sven Schuetz wrote:
> > Hi Seokmann,
> >> Do we have time table for this support to make it available in the
> >> upstream?
> >> I think it would be good to have the feature in 2.6.30 kernel, if
> >> possible.
> >> I will continue to work on and add rest of helper function in the driver.
> >>
> >> Thank you,
> >> Seokmann
> >>
> >> ---
> >
> > I am preparing a patch for our zfcp driver and would love to see both
> > James&your fc_transport patch as well as the patches for our drivers in
> > 2.6.30 too :)
> >
> > Tomo, Boaz - since the current implemantation is based on that patch:
> > http://marc.info/?l-linux-scsi&m=122785157116659&w=2
> > which is not agreed upon - can we start the discussion again?
> > My understanding from the discussion back then was that Boaz proposed a
> > change to the patch which Tomo agreed to. See here:
> > http://marc.info/?l=linux-scsi&m=122812818916080&w=2
> > However, a new version of the patch was never posted. So would a patch
> > with the proposed change be ok for the two of you which could be posted
> > to Jens?
> > I really appreciate all of your efforts, thanks a lot for that :-)
> > Have a nice weekend,
> > Sven
>
> My humble opinion is: That none of the patches should go in. It is easy
> enough to use the API as it is, and it is more correct then any of the
> suggested alternatives.

It's pretty clear that the current API is pretty confusing. If not,
why do you need to tell SCSI developers how to use it again and again?

Please don't say 'add comments along with the API'. Commenting doesn't
fix the confusing API. People can use good API without any
explanation.

But it's better to live with the current API for now. We can fix the
API latter. I'll read Tejun's block cleanup patchset and figure out
what to do.