RE: [Fwd: Re: iscsi update for 2.6.29]

RE: [Fwd: Re: iscsi update for 2.6.29]

[Karen Xie]

Hi, Boaz,

Sorry, I must have missed your bidi comment. I tried to search the archive but does not seem to be able to find anything. Do you mind forward me the email if you still have it?

Sorry for the inconvenience.
Thanks,
Karen

-------- Original Message --------
Subject: Re: iscsi update for 2.6.29
Date: Tue, 02 Dec 2008 19:10:49 +0200
From: Boaz Harrosh <bharrosh@panasas.com>
To: michaelc@cs.wisc.edu
CC: linux-scsi@vger.kernel.org
References: <1228199536-12595-1-git-send-email-michaelc@cs.wisc.edu>

michaelc@cs.wisc.edu wrote:
> This patchset is for 2.6.29. This should be the final patches
> to prepare the iscsi layer for cxgb3i, which looks like it
> has gone through the netdev review and will be sent here next
> shortly.
> 
> This patchset was made over scsi-misc, and the fix here.
> http://marc.info/?l=linux-scsi&m=122815519326207&w=2
> (the fix in that email does not conflict with this patchset
> and can be applied over or before these patches).
> 
> cxgb3i adds a new offload model. Where qla4xxx offloaded pretty
> much everything, and bnx2i offloaded the iscsi sequence processing
> (give it the iscsi scsi command pdu and the offload engine will
> handle everything between), cxgb3i offloads operations like
> digest, padding, and data transfers. It relies on the iscsi layer
> for the sequence state machine, so this patchset is basically
> just breaking up iscsi_tcp into a lib layer so cxgb3i can share
> the code.
> 

OK I tested that lot finally, and it's good. I'm able to bang
bidi commands on it and it seems to works. exofs (was osdfs) mounts
and works as before. I'll let it run through the night and see if
it holds. (It should)

So the generic layer of this patchset is tested.

I have sent comments about bidi mistakes made in the cxgb3i side
of this patchset but never got a response and it seems they have not
been fixed. But I might have missed the fixes. is the cxgb3i branch on
git://git.kernel.org/pub/scm/linux/kernel/git/mnc/linux-2.6-iscsi.git
the latest iteration of these patches? I'll have another look if you want?

If you want I can help you set up a SW only OSD setup, to test if cxgb3i
is bidi clean. What about the other accel cards?

One more test that I never did is OSD (bidi) commands with header+data
digest enabled. Now with OSC's OSD target over TOMO's stgt I should be
able to test that. IBM's target did not support it because OSD has its
own digest stuff. TOMO's stgt does supports header+data digest right?
I should run these tests later this week. Just to make sure the digest
stuff is bidi safe. I'm sure it is but just that I never tested it.

Thanks
Boaz

Re: [Fwd: Re: iscsi update for 2.6.29]

[Boaz Harrosh]

http://groups.google.com/group/open-iscsi/msg/dd660ab6b0def64f?&q=cxgb3i%3A+cxgb3+iSCSI+initiator+boaz

Karen Xie wrote:
> Hi, Boaz,
> 
> Sorry, I must have missed your bidi comment. I tried to search the archive but does not seem to be able to find anything. Do you mind forward me the email if you still have it?
> 
> Sorry for the inconvenience.
> Thanks,
> Karen
> 
> -------- Original Message --------
> Subject: Re: iscsi update for 2.6.29
> Date: Tue, 02 Dec 2008 19:10:49 +0200
> From: Boaz Harrosh <bharrosh@panasas.com>
> To: michaelc@cs.wisc.edu
> CC: linux-scsi@vger.kernel.org
> References: <1228199536-12595-1-git-send-email-michaelc@cs.wisc.edu>
> 
> michaelc@cs.wisc.edu wrote:
>> This patchset is for 2.6.29. This should be the final patches
>> to prepare the iscsi layer for cxgb3i, which looks like it
>> has gone through the netdev review and will be sent here next
>> shortly.
>>
>> This patchset was made over scsi-misc, and the fix here.
>> http://marc.info/?l=linux-scsi&m=122815519326207&w=2
>> (the fix in that email does not conflict with this patchset
>> and can be applied over or before these patches).
>>
>> cxgb3i adds a new offload model. Where qla4xxx offloaded pretty
>> much everything, and bnx2i offloaded the iscsi sequence processing
>> (give it the iscsi scsi command pdu and the offload engine will
>> handle everything between), cxgb3i offloads operations like
>> digest, padding, and data transfers. It relies on the iscsi layer
>> for the sequence state machine, so this patchset is basically
>> just breaking up iscsi_tcp into a lib layer so cxgb3i can share
>> the code.
>>
> 
> OK I tested that lot finally, and it's good. I'm able to bang
> bidi commands on it and it seems to works. exofs (was osdfs) mounts
> and works as before. I'll let it run through the night and see if
> it holds. (It should)
> 
> So the generic layer of this patchset is tested.
> 
> I have sent comments about bidi mistakes made in the cxgb3i side
> of this patchset but never got a response and it seems they have not
> been fixed. But I might have missed the fixes. is the cxgb3i branch on
> git://git.kernel.org/pub/scm/linux/kernel/git/mnc/linux-2.6-iscsi.git
> the latest iteration of these patches? I'll have another look if you want?
> 
> If you want I can help you set up a SW only OSD setup, to test if cxgb3i
> is bidi clean. What about the other accel cards?
> 
> One more test that I never did is OSD (bidi) commands with header+data
> digest enabled. Now with OSC's OSD target over TOMO's stgt I should be
> able to test that. IBM's target did not support it because OSD has its
> own digest stuff. TOMO's stgt does supports header+data digest right?
> I should run these tests later this week. Just to make sure the digest
> stuff is bidi safe. I'm sure it is but just that I never tested it.
> 
> Thanks
> Boaz

Re: [Fwd: Re: iscsi update for 2.6.29]

[Boaz Harrosh]

Boaz Harrosh wrote:
> http://groups.google.com/group/open-iscsi/msg/dd660ab6b0def64f?&q=cxgb3i%3A+cxgb3+iSCSI+initiator+boaz
> 
> Karen Xie wrote:
>> Hi, Boaz,
>>
>> Sorry, I must have missed your bidi comment. I tried to search the archive but does not seem to be able to find anything. Do you mind forward me the email if you still have it?
>>
>> Sorry for the inconvenience.
>> Thanks,
>> Karen
>>

Karen Hi.

Please point me to the latest code. Do you have it on a public git/web
based on Mike's latest kernel?

Would you be interested in testing a bidi setup with SW OSD target and
initiator? One machine runs a user-mode target the second an initiator
on top of open-iscsi. This way you can test full bidi and extended cdb
commands.

Thanks
Boaz

RE: [Fwd: Re: iscsi update for 2.6.29]

[Karen Xie]

Hi, Boaz,

I've just sent the patch out to the list, you can apply the patch to the cxgb3i branch of Mike's linux-2.6-iscsi tree. The patchset includes a file cxgb3i.txt in Document/scsi. I hope it addresses some of your comments.

And, yes, I am interested to have bidi setup. How do I go about getting and setting up the OSD sw target?

Thanks,
Karen

-----Original Message-----
From: Boaz Harrosh [mailto:bharrosh@panasas.com]
Sent: Wed 12/3/2008 12:43 AM
To: Karen Xie
Cc: linux-scsi@vger.kernel.org; michaelc@cs.wisc.edu
Subject: Re: [Fwd: Re: iscsi update for 2.6.29]
 
Boaz Harrosh wrote:
> http://groups.google.com/group/open-iscsi/msg/dd660ab6b0def64f?&q=cxgb3i%3A+cxgb3+iSCSI+initiator+boaz
> 
> Karen Xie wrote:
>> Hi, Boaz,
>>
>> Sorry, I must have missed your bidi comment. I tried to search the archive but does not seem to be able to find anything. Do you mind forward me the email if you still have it?
>>
>> Sorry for the inconvenience.
>> Thanks,
>> Karen
>>

Karen Hi.

Please point me to the latest code. Do you have it on a public git/web
based on Mike's latest kernel?

Would you be interested in testing a bidi setup with SW OSD target and
initiator? One machine runs a user-mode target the second an initiator
on top of open-iscsi. This way you can test full bidi and extended cdb
commands.

Thanks
Boaz

Re: [Fwd: Re: iscsi update for 2.6.29]

[Boaz Harrosh]

Karen Xie wrote:
> Hi, Boaz,
> 

Hi Karen Xie

> I've just sent the patch out to the list, you can apply the patch to the cxgb3i branch of Mike's
> linux-2.6-iscsi tree. The patchset includes a file cxgb3i.txt in Document/scsi. I hope it addresses
> some of your comments.
> 

I will review the full source code during the next week, and see if I can spot any problems.
Specifically, I will check for extended-commands/AHS and bidi problems.

Should the HW support bidi and extended-commands? that is: it will need two scaterlists in parallel,
and support for AHSs with the spilt command (first 16 bytes in main command header and the rest in an AHS).
Perhaps, if the HW does not support this in accelerated mode, then it should switch to SW mode (regular
TCP/IP) when receiving a bidi-command.

> And, yes, I am interested to have bidi setup. How do I go about getting and setting up the OSD sw target?
> 

Thank you, that could be nice.

Start at http://open-osd.org, follow the links to the target page. Please tell me if you have
any problems or questions, and I will be happy to help.
The Target side is easy, just git-clone, compile and run. Initiator is a bit more involved but
should work also.

> Thanks,
> Karen
> 

Thank you
Boaz

> -----Original Message-----
> From: Boaz Harrosh [mailto:bharrosh@panasas.com]
> Sent: Wed 12/3/2008 12:43 AM
> To: Karen Xie
> Cc: linux-scsi@vger.kernel.org; michaelc@cs.wisc.edu
> Subject: Re: [Fwd: Re: iscsi update for 2.6.29]
>  
> Boaz Harrosh wrote:
>> http://groups.google.com/group/open-iscsi/msg/dd660ab6b0def64f?&q=cxgb3i%3A+cxgb3+iSCSI+initiator+boaz
>>
>> Karen Xie wrote:
>>> Hi, Boaz,
>>>
>>> Sorry, I must have missed your bidi comment. I tried to search the archive but does not seem to be able to find anything. Do you mind forward me the email if you still have it?
>>>
>>> Sorry for the inconvenience.
>>> Thanks,
>>> Karen
>>>
> 
> Karen Hi.
> 
> Please point me to the latest code. Do you have it on a public git/web
> based on Mike's latest kernel?
> 
> Would you be interested in testing a bidi setup with SW OSD target and
> initiator? One machine runs a user-mode target the second an initiator
> on top of open-iscsi. This way you can test full bidi and extended cdb
> commands.
> 
> Thanks
> Boaz
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

RE: [Fwd: Re: iscsi update for 2.6.29]

[Karen Xie]

Hi, Boaz,

Yeah, let me know if you spot anything. 

The hw does support AHS, it is just the current software does not support transmitting AHS as mentioned by Mike. But it should be easy to fix. On receive, I believe the code is already able to handle AHS.

Thanks for the open-osd link. I will check it out.

Karen

-----Original Message-----
From: Boaz Harrosh on behalf of Boaz Harrosh
Sent: Sun 12/7/2008 5:05 AM
To: Karen Xie
Cc: linux-scsi@vger.kernel.org; michaelc@cs.wisc.edu
Subject: Re: [Fwd: Re: iscsi update for 2.6.29]
 
Karen Xie wrote:
> Hi, Boaz,
> 

Hi Karen Xie

> I've just sent the patch out to the list, you can apply the patch to the cxgb3i branch of Mike's
> linux-2.6-iscsi tree. The patchset includes a file cxgb3i.txt in Document/scsi. I hope it addresses
> some of your comments.
> 

I will review the full source code during the next week, and see if I can spot any problems.
Specifically, I will check for extended-commands/AHS and bidi problems.

Should the HW support bidi and extended-commands? that is: it will need two scaterlists in parallel,
and support for AHSs with the spilt command (first 16 bytes in main command header and the rest in an AHS).
Perhaps, if the HW does not support this in accelerated mode, then it should switch to SW mode (regular
TCP/IP) when receiving a bidi-command.

> And, yes, I am interested to have bidi setup. How do I go about getting and setting up the OSD sw target?
> 

Thank you, that could be nice.

Start at http://open-osd.org, follow the links to the target page. Please tell me if you have
any problems or questions, and I will be happy to help.
The Target side is easy, just git-clone, compile and run. Initiator is a bit more involved but
should work also.

> Thanks,
> Karen
> 

Thank you
Boaz

> -----Original Message-----
> From: Boaz Harrosh [mailto:bharrosh@panasas.com]
> Sent: Wed 12/3/2008 12:43 AM
> To: Karen Xie
> Cc: linux-scsi@vger.kernel.org; michaelc@cs.wisc.edu
> Subject: Re: [Fwd: Re: iscsi update for 2.6.29]
>  
> Boaz Harrosh wrote:
>> http://groups.google.com/group/open-iscsi/msg/dd660ab6b0def64f?&q=cxgb3i%3A+cxgb3+iSCSI+initiator+boaz
>>
>> Karen Xie wrote:
>>> Hi, Boaz,
>>>
>>> Sorry, I must have missed your bidi comment. I tried to search the archive but does not seem to be able to find anything. Do you mind forward me the email if you still have it?
>>>
>>> Sorry for the inconvenience.
>>> Thanks,
>>> Karen
>>>
> 
> Karen Hi.
> 
> Please point me to the latest code. Do you have it on a public git/web
> based on Mike's latest kernel?
> 
> Would you be interested in testing a bidi setup with SW OSD target and
> initiator? One machine runs a user-mode target the second an initiator
> on top of open-iscsi. This way you can test full bidi and extended cdb
> commands.
> 
> Thanks
> Boaz
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>