* [PATCH] qla2xxx: Fix for incorrect unconditionally interrupts enabling on IRQ context
@ 2008-12-10 16:22 Vladislav Bolkhovitin
0 siblings, 0 replies; only message in thread
From: Vladislav Bolkhovitin @ 2008-12-10 16:22 UTC (permalink / raw)
To: linux-driver; +Cc: linux-scsi
A rather trivial patch. Function qla2x00_schedule_rport_del() can be called on IRQ
context, so it can't unconditionally enable interrupts. Spotted by lockdep.
This patch is against 2.6.27.2, but applies also on 2.6.28-rc7.
Signed-off-by: Vladislav Bolkhovitin <vst@vlnb.net>
qla_os.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff -upr linux-2.6.27.2/drivers/scsi/qla2xxx/qla_os.c linux-2.6.27.2/drivers/scsi/qla2xxx/qla_os.c
--- linux-2.6.27.2/drivers/scsi/qla2xxx/qla_os.c 2008-10-21 13:57:15.000000000 +0400
+++ linux-2.6.27.2/drivers/scsi/qla2xxx/qla_os.c 2008-12-05 11:14:21.000000000 +0300
@@ -1862,9 +1885,10 @@ qla2x00_schedule_rport_del(struct scsi_q
rport = fcport->rport;
if (defer) {
- spin_lock_irq(ha->host->host_lock);
+ unsigned long flags;
+ spin_lock_irqsave(ha->host->host_lock, flags);
fcport->drport = rport;
- spin_unlock_irq(ha->host->host_lock);
+ spin_unlock_irqrestore(ha->host->host_lock, flags);
set_bit(FCPORT_UPDATE_NEEDED, &pha->dpc_flags);
qla2xxx_wake_dpc(pha);
} else
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-12-10 16:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-10 16:22 [PATCH] qla2xxx: Fix for incorrect unconditionally interrupts enabling on IRQ context Vladislav Bolkhovitin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).