* [PATCH mm/next] libfc: uses/select CRC32
[not found] <200901052050.n05Kox9j012519@imap1.linux-foundation.org>
@ 2009-01-06 0:05 ` Randy Dunlap
2009-02-03 18:21 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2009-01-06 0:05 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, jejb, scsi
From: Randy Dunlap <randy.dunlap@oracle.com>
libfc uses crc32 functions, so cause it to be built
via select:
drivers/built-in.o: In function `fc_frame_crc_check':
(.text+0x75dae): undefined reference to `crc32_le'
drivers/built-in.o: In function `fc_fcp_recv':
fc_fcp.c:(.text+0x7b919): undefined reference to `crc32_le'
fc_fcp.c:(.text+0x7b9d5): undefined reference to `crc32_le'
fc_fcp.c:(.text+0x7ba54): undefined reference to `crc32_le'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/scsi/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- mmotm-2009-0105-1250.orig/drivers/scsi/Kconfig
+++ mmotm-2009-0105-1250/drivers/scsi/Kconfig
@@ -609,6 +609,7 @@ config SCSI_FLASHPOINT
config LIBFC
tristate "LibFC module"
select SCSI_FC_ATTRS
+ select CRC32
---help---
Fibre Channel library module
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH mm/next] libfc: uses/select CRC32
2009-01-06 0:05 ` [PATCH mm/next] libfc: uses/select CRC32 Randy Dunlap
@ 2009-02-03 18:21 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2009-02-03 18:21 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel, akpm, jejb, scsi
* Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> libfc uses crc32 functions, so cause it to be built
> via select:
>
> drivers/built-in.o: In function `fc_frame_crc_check':
> (.text+0x75dae): undefined reference to `crc32_le'
> drivers/built-in.o: In function `fc_fcp_recv':
> fc_fcp.c:(.text+0x7b919): undefined reference to `crc32_le'
> fc_fcp.c:(.text+0x7b9d5): undefined reference to `crc32_le'
> fc_fcp.c:(.text+0x7ba54): undefined reference to `crc32_le'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Hm, is there a reason why this fix has not gone upstream? I'm still
stumbling across it in build tests with a latest -git base.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-03 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200901052050.n05Kox9j012519@imap1.linux-foundation.org>
2009-01-06 0:05 ` [PATCH mm/next] libfc: uses/select CRC32 Randy Dunlap
2009-02-03 18:21 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).