Re: [PATCH 07/18] osd_ktests: Add basic OSD tests

[Boaz Harrosh <bharrosh@panasas.com>]

FUJITA Tomonori wrote:
> On Tue, 06 Jan 2009 16:56:23 +0200
> Boaz Harrosh <bharrosh@panasas.com> wrote:
> 
>> FUJITA Tomonori wrote:
>>> On Tue,  6 Jan 2009 16:17:16 +0200
>>> Why do we need in-kernel test suite?
>> It must be in kernel, because it tests the in-kernel library.
>> However it could be in it's own Module, which makes it more
>> complicated, but doable.
> 
> Why do we need the code to tests the in-kernel library?
> 
> I expect that you guys have tested the osd in-kernel library heavily
> and will. I don't think people want to do the same. Then why do we
> need to have the test suite in mainline?
> 

one - There are things that can regress. Lots of stuff in current
kernel are only used by OSD, like bidi and varlen. all the way down
to LLDs. So this should be a regression test for future kernels.

two - To test compatibility, some thing is broken, the test can help
pinpoint the problems. So it's a debugging tool.

Sure, the lib itself is heavily tested but this is to test the
round trip.

> 
>> Please note that the submitted tests are the bare minimum and
>> will be enhanced in the future. Perhaps later when the test grow
>> I will put them in their own module.
> 
> If you can have it as a module, it's very easy for you guys to keep it
> out-of-mainline.

I have it out-of-mainline for a long time ;). I can do that. I thought that
I should provide a minimal test, so developers can check if they broke
something. If no one wants it I'll remove it.

Thanks
Boaz